Use context-fill for the treecol icons

RESOLVED FIXED in Thunderbird 64.0

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 64.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Actually we hard code the colour inside the SVG icons. It would be better to use context-fill to be flexible what colour we use in the treecols.
Together with the change to context-fill, I moved the icons to the shared directory to use the same for all platforms. Linux and Windows used already the same ones in their own directories. Mac still used PNG icons.

I had to change some paddings for Mac because before the icons where 16px and now 12px. But now they are aligned with the icons in the thread tree again.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9007549 - Flags: review?(jorgk)
Comment on attachment 9007549 [details] [diff] [review]
treecol-image.patch

Nice clean-up job!

Is this a "spot the difference" review? I see none. I noticed that the thread icon in the column header is smaller and darker an in the actual thread pane, but that's the same in TB 60.
Attachment #9007549 - Flags: review?(jorgk) → review+
There should be no difference. And the thread icon is the same. The only difference is that the icon is optimized and it uses the treecol text color which is the same which was before hard coded.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a682d50b9f77
Use context-fill for the treecol icons. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.