1489853 - keyword.enabled not honored with trailing colon for about:

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[Franck (Wip)]

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180830143136

Steps to reproduce:
  - start Firefox with a clean profile
  - open about:config
  - change browser.fixup.alternate.enabled to false
  - change keyword.enabled to false
  - in the address bar, type any random single word followed with a colon without space
    e.g. "test:" or "about:"
  - press enter

Actual results:
  the default search engine is used to search the typed word (without the colon)

Expected results:
  the error page "Hmm. We’re having trouble finding that site." should have been displayed

This is a regression from Firefox 61.

Comment 1

[Paul]

FYI this behaviour is also observed for about: when keyword.enabled=true, which likewise used to display the error page.

Not implying that's incorrect though. The handling of URI schemes has changed a lot, e.g. keyword: stopped working some time ago. The behaviour may be more consistent this way.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Paul from comment #1)
> FYI this behaviour is also observed for about: when keyword.enabled=true,
> which likewise used to display the error page.

See bug 1239708 comment 232 and following for that part.

Comment 3

[Marco Bonardo [:mak]]

Right now this only reproduces on about:, doesn't reproduce on test: or other random strings. We should investigate why about is special in this case, when keyword.enabled is false any string should always try to be handled as a url, never as a search.

Comment 4

[Marco Bonardo [:mak]]

This also happens for "https:/", "https://", "http:/" or "http://"

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Regressed by	bug 1239708	bug 1591175

For more information, please visit auto_nag documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1239708

:adw, since you are the author of the regressor, bug 1239708, could you take a look?

For more information, please visit auto_nag documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1239708