Mismatched suggestions for autofilling the about: pages

NEW
Unassigned

Status

()

defect
P3
normal
9 months ago
8 months ago

People

(Reporter: yfdyh000, Unassigned)

Tracking

64 Branch
All
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

Reporter

Description

9 months ago
Steps to reproduce:
1. Open the latest Nightly with a profile with some history.
2. Type the "about:" to urlbar.
3. Type the "about:a" to urlbar.


Actual results:
1. If you test this feature with a new profile, it looks good, some about: pages are listed on the suggestions, but their position is unstable.
2. In step 2 with old profile, you will see the history listing that is completely unrelated to about: pages.
3. In step 3 with old profile, you will see the "about:about" has been correctly filled in, but the suggestions is mostly not related to about: pages.


Expected results:
about: pages listed as address bar suggestions with normal priority.
(In reply to YF (Yang) from comment #0)
> Actual results:
> 2. In step 2 with old profile, you will see the history listing that is
> completely unrelated to about: pages.

This is due to recent changes where we strip any scheme, included about:, searching about: is the same as searching an empty string. We may want to fix it.

> 3. In step 3 with old profile, you will see the "about:about" has been
> correctly filled in, but the suggestions is mostly not related to about:
> pages.

we have only one entry per about:, and it has a low frecency.

Basically by the current design what you see is not a bug, though I think we should better handle typed schemes, when they are not http/https. That is what we were doing before, I think new autofill changed that code to always strip any scheme.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Whiteboard: [fxsearch]

Updated

9 months ago
See Also: → 1489853
(In reply to Marco Bonardo [::mak] from comment #1)
> This is due to recent changes where we strip any scheme, included about:,
> searching about: is the same as searching an empty string. We may want to
> fix it.

This happens for any string that ends in :.  You can type diowejidoj: and the results will be the history results (except for the heuristic result).  That doesn't seem right IMO.  It may be worth filing a separate bug for that, depending on whether this bug really encompasses it, which is hard to tell without working on it first.
imo, we should go back to only ignore http/s, it was just working better.
You need to log in before you can comment on or make changes to this bug.