1489923 - Dropmarker area is too large on macOS

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-09-09 at 9.47.06 PM.png

width: 16px; seems to be causing this.

Comment 1

[Dão Gottwald [:dao]]

width: 16px was there before bug 1487765, though. Could this be a regression from bug 1470872?

Comment 2

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #1)
> width: 16px was there before bug 1487765, though. Could this be a regression
> from bug 1470872?

Yeah, it could well be. I’ll see if I’ll have time to check using mozregression.

Comment 3

[Tim Nguyen :ntim]

Hi Brindusa, would it be possible to get a regression range for this ?

Comment 4

[Daniel Bodea [:danibodea]]

Can I get a STR on this issue, please?

Comment 5

[Tim Nguyen :ntim]

(In reply to Bodea Daniel [:danibodea] from comment #4)
> Can I get a STR on this issue, please?

STR:
- Open the add-ons manager on the "Extensions" tab


ER:
- Unequal amount of white space on the left and the right on the "Tools" button, see attachment 9007656 [details]

AR:
- There should be the same amount of white space.

Comment 6

[Tim Nguyen :ntim]

Looks like this has been fixed by bug 1492130. It would still be nice to know what caused this however, in case we need to uplift a fix to Beta.

Comment 7

[Tim Nguyen :ntim]

Attachment: Expected result

Comment 8

[Tim Nguyen :ntim]

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #5)
> ER:
> - Unequal amount of white space on the left and the right on the "Tools"
> button, see attachment 9007656 [details]
> 
> AR:
> - There should be the same amount of white space.

Urgh, I swapped the ER and the AR.

Comment 9

[Daniel Bodea [:danibodea]]

I have regressed the introduction of the issue and these are my results:
31:51.04 INFO: No more inbound revisions, bisection finished.
31:51.04 INFO: Last good revision: 96ecf3102f8d7eaf0cb7ecab561a07e4e4bcade7
31:51.04 INFO: First bad revision: 05f13f9fe2d3204d0a21ce71c196bb89b25f46fd
31:51.04 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=96ecf3102f8d7eaf0cb7ecab561a07e4e4bcade7&tochange=05f13f9fe2d3204d0a21ce71c196bb89b25f46fd

Then, just to be sure, I have regressed the introduction of the fix and these are my results:
11:25.80 INFO: No more inbound revisions, bisection finished.
11:25.80 INFO: First good revision: a6b130810bc42f125709fe40c2e26fe9f5f985f6
11:25.80 INFO: Last bad revision: 1330a9eb3da56d783aefabe063764eb55e9adadc
11:25.80 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1330a9eb3da56d783aefabe063764eb55e9adadc&tochange=a6b130810bc42f125709fe40c2e26fe9f5f985f6

Also, it looks like it occurs on Firefox Beta v63.0b9, but not on the latest Nightly (2018-09-25).

Furthermore, I have to mention that the results may be incorrect because the reproduction of the issue varied between the builds that mozregression suggested for test. To make myself more easily understood, on some builds I have tested during the mozregression process, the blank space at the right of the button's icon was bigger in some cases and smaller in others, while still not perfectly centered horizontally.

Comment 10

[Daniel Bodea [:danibodea]]

Awesome! I am marking this issue as verified.
Thank you!