Closed
Bug 1487765
Opened 6 years ago
Closed 6 years ago
Remove fallback styling from dropmarker.css
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.53 KB,
patch
|
Details | Diff | Splinter Review |
Followup from bug 1487496. dropmarker.css already doesn't have any fallback styling on Linux -- we depend entirely on -moz-appearance. We can probably do the same on Windows and Mac. https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=b59263e67753dfa3ec5fd419c489eff6450fbe84&newProject=try&newRev=840c847fdc24efb228e2a3ed3b53eba51a77d357
|
Assignee | |
Comment 1•6 years ago
|
||
Comment on attachment 9005617 [details] [diff] [review] patch Tested on Win7 classic to make sure we don't replicate bug 1481544. -moz-appearance: -moz-menulist-button seems to work fine there.
Attachment #9005617 -
Flags: review?(ntim.bugs)
|
||
Updated•6 years ago
|
Attachment #9005617 -
Flags: review?(ntim.bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/86c2698513ab Remove fallback styling from dropmarker.css. r=ntim
|
||
Comment 3•6 years ago
|
||
Backed out changeset 86c2698513ab (bug 1487765)for mochitest failures on test_focus.xul Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/bbdff09506cf3905125859481301a24ae5aa887c Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=86c2698513abbcf2e20a10dbec983baa532240c2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=197048772&repo=mozilla-inbound :dao could you please take a look?
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(dao+bmo)
Priority: -- → P3
|
|
Assignee | |
Comment 4•6 years ago
|
||
Attachment #9005617 -
Attachment is obsolete: true
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/598ede9c5a5d Remove fallback styling from dropmarker.css. r=ntim
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/598ede9c5a5d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•