Closed Bug 1487765 Opened Last year Closed Last year

Remove fallback styling from dropmarker.css

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Followup from bug 1487496.

dropmarker.css already doesn't have any fallback styling on Linux -- we depend entirely on -moz-appearance. We can probably do the same on Windows and Mac.

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=b59263e67753dfa3ec5fd419c489eff6450fbe84&newProject=try&newRev=840c847fdc24efb228e2a3ed3b53eba51a77d357
Comment on attachment 9005617 [details] [diff] [review]
patch

Tested on Win7 classic to make sure we don't replicate bug 1481544. -moz-appearance: -moz-menulist-button seems to work fine there.
Attachment #9005617 - Flags: review?(ntim.bugs)
Attachment #9005617 - Flags: review?(ntim.bugs) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86c2698513ab
Remove fallback styling from dropmarker.css. r=ntim
Flags: needinfo?(dao+bmo)
Priority: -- → P3
Attached patch patch v2Splinter Review
Attachment #9005617 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/598ede9c5a5d
Remove fallback styling from dropmarker.css. r=ntim
https://hg.mozilla.org/mozilla-central/rev/598ede9c5a5d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1489743
Depends on: 1489783
Depends on: 1489923
No longer depends on: 1489923
Depends on: 1491108
Depends on: 1491400
You need to log in before you can comment on or make changes to this bug.