Closed
Bug 1489971
Opened 6 years ago
Closed 6 years ago
0.79% installer size (osx-cross) regression on push 238267dc78ec3dd4bbf2f996bea4e877547e69e8 (Fri Sep 7 2018)
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jmaher, Unassigned)
References
Details
(Keywords: regression)
We have detected a build metrics regression from push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=238267dc78ec3dd4bbf2f996bea4e877547e69e8
As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
1% installer size osx-cross opt 72,067,421.92 -> 72,639,958.58
You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=15735
On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.
To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics
Reporter | ||
Comment 1•6 years ago
|
||
:glandium, I found that this is clearly showing an installer regression in this range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f51b3b73cd4b87cffde3e687657e1371fc9a489&tochange=238267dc78ec3dd4bbf2f996bea4e877547e69e8
there are 2 patches you landed, 1 for asan, the other for clang annotations- I am not sure which one but I assume asan doesn't matter for osx, so I picked bug 1488631 as the root cause. Can you help determine if this is expected?
Component: General → Source Code Analysis
Flags: needinfo?(mh+mozilla)
Product: Testing → Firefox Build System
Comment 2•6 years ago
|
||
Not really expected, but it makes sense. The annotations have an impact on code generation, including optimization. That's why we removed the useless ones. I wouldn't be surprised if the same push showed performance improvements.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → WONTFIX
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•