Closed Bug 1490508 Opened Last year Closed Last year

CSS mask not applied correctly when recommendation is expanded and url bar text is selected

Categories

(Firefox :: Messaging System, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 64
Iteration:
64.3 - Oct 12
Tracking Status
firefox63 + fixed
firefox64 --- fixed

People

(Reporter: ahillier, Assigned: ahillier)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

As Bryan pointed out in Slack, this shouldn't happen (see attached image)
Iteration: --- → 64.1 (Sep 14)
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e1b7dd62028f851e022e19667bed5ee77ffccded
Fix Bug 1490508 - Collapse the recommendation when the urlbar is focused (#4414)
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Reopening because there's also a Mozilla Central browser CSS patch for this bug https://phabricator.services.mozilla.com/D5618
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Ed Lee :Mardak has approved the revision.
Attachment #9008252 - Flags: review+
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43e67f28b425
Apply mask correctly to CFR recommendation on urlbar focus r=Mardak
https://hg.mozilla.org/mozilla-central/rev/43e67f28b425
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Blocks: 1489962
Hi Adam, could you please request beta uplift for this?
Flags: needinfo?(a.hillier)
Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1484030
[User impact if declined]: Low-Medium - it's a bad experience but will be rarely encountered by a minority of users
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1489962 is an export patch containing the corresponding commit to the Activity Stream GitHub repo that I think will also be uplifted, but strictly speaking this patch can be uplifted on its own.
[Is the change risky?]: No
[Why is the change risky/not risky?]: It consists of some minor browser CSS changes that have been manually verified
[String changes made/needed]: None
Flags: needinfo?(a.hillier)
Attachment #9008252 - Flags: approval-mozilla-beta?
(In reply to Adam Hillier :ahillier from comment #9)
> [List of other uplifts needed for the feature/fix]: Bug 1489962 is an export
> patch containing the corresponding commit to the Activity Stream GitHub repo
> that I think will also be uplifted, but strictly speaking this patch can be
> uplifted on its own.
We should update the patch in this bug and request uplift on the combined change. We won't be uplifting bug 1489962's patch.
Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

The patch in bug 1489962 got backed out and there was no uplift request in the other bug.
Attachment #9008252 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout

Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
Assignee: a.hillier → nobody
Iteration: 64.1 (Sep 14) → 64.3 (Oct 12)
Priority: P1 → P2
Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Ursula Sarracini (:ursula) has approved the revision.
Attachment #9013382 - Flags: review+
Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

See comment 9 except there's no other dependent bugs as the patch here picks out the one relevant activity-stream change from the larger export.
Attachment #9013382 - Flags: approval-mozilla-beta?
Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Fix for a visual bug in primary UI, uplift approved for 63 beta 12.
Attachment #9013382 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee: nobody → a.hillier
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.