1490508 - CSS mask not applied correctly when recommendation is expanded and url bar text is selected

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Adam Hillier :ahillier]

Attachment: Screen Shot 2018-09-11 at 15.38.17.png

As Bryan pointed out in Slack, this shouldn't happen (see attached image)

Comment 1

[Adam Hillier :ahillier]

Attachment: Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4414

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e1b7dd62028f851e022e19667bed5ee77ffccded
Fix Bug 1490508 - Collapse the recommendation when the urlbar is focused (#4414)

Comment 4

[Adam Hillier :ahillier]

Reopening because there's also a Mozilla Central browser CSS patch for this bug https://phabricator.services.mozilla.com/D5618

Comment 5

[Ed Lee :Mardak]

Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Ed Lee :Mardak has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43e67f28b425
Apply mask correctly to CFR recommendation on urlbar focus r=Mardak

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/43e67f28b425

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Adam, could you please request beta uplift for this?

Comment 9

[Adam Hillier :ahillier]

Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1484030
[User impact if declined]: Low-Medium - it's a bad experience but will be rarely encountered by a minority of users
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1489962 is an export patch containing the corresponding commit to the Activity Stream GitHub repo that I think will also be uplifted, but strictly speaking this patch can be uplifted on its own.
[Is the change risky?]: No
[Why is the change risky/not risky?]: It consists of some minor browser CSS changes that have been manually verified
[String changes made/needed]: None

Comment 10

[Ed Lee :Mardak]

(In reply to Adam Hillier :ahillier from comment #9)
> [List of other uplifts needed for the feature/fix]: Bug 1489962 is an export
> patch containing the corresponding commit to the Activity Stream GitHub repo
> that I think will also be uplifted, but strictly speaking this patch can be
> uplifted on its own.
We should update the patch in this bug and request uplift on the combined change. We won't be uplifting bug 1489962's patch.

Comment 11

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8dde92f89a24

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9008252 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

The patch in bug 1489962 got backed out and there was no uplift request in the other bug.

Comment 13

[Ed Lee :Mardak]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout

Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70

Comment 14

[Ed Lee :Mardak]

Attachment: Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Uplifts https://hg.mozilla.org/mozilla-central/rev/43e67f28b425 and https://github.com/mozilla/activity-stream/commit/e1b7dd62028f851e022e19667bed5ee77ffccded

Comment 15

[Ursula Sarracini (:ursula)]

Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Ursula Sarracini (:ursula) has approved the revision.

Comment 16

[Ed Lee :Mardak]

Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

See comment 9 except there's no other dependent bugs as the patch here picks out the one relevant activity-stream change from the larger export.

Comment 17

[Pascal Chevrel:pascalc]

Comment on attachment 9013382 [details]
Bug 1490508 - Apply mask correctly to CFR recommendation on urlbar focus

Fix for a visual bug in primary UI, uplift approved for 63 beta 12.

Comment 18

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd305e92721b

Comment 19

[Ed Lee :Mardak]

Looks like attachment 9008252 [details] instead of attachment 9013382 [details]

Comment 20

[Ed Lee :Mardak]

Attachment: 63b11 vs 63b12 vs 64 nightly

Comment 21

[Ed Lee :Mardak]

I landed the rest as https://hg.mozilla.org/releases/mozilla-beta/rev/b80fb23f66ea