Closed Bug 1490950 Opened Last year Closed Last year

[remote-dbg-next] Investigate why order matters when destroying about:debugging

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: jdescottes, Assigned: daisuke)

References

Details

Attachments

(1 file)

Follow up to Bug 1489219.

In the destroy method of aboutdebugging-new/aboutdebugging.js : 

  async destroy() {
    L10nRegistry.removeSource("aboutdebugging");
    removeNetworkLocationsObserver(this.onNetworkLocationsUpdated);
    await this.actions.disconnectRuntime();
    setDebugTargetCollapsibilities(this.store.getState().ui.debugTargetCollapsibilities);
    unmountComponentAtNode(this.mount);
  },

The call to `removeNetworkLocationsObserver` absolutely has to happen before `await this.actions.disconnectRuntime()`. We should check why this is and if it can be avoided.
I am making a test bug 1489221 though, `setDebugTargetCollapsibilities` is not called at all since it looks like `await this.actions.disconnectRuntime()` waits forever.
I'm not sure but `this.actions.disconnectRuntime()` does not return Promise??
Will investigate this one.
Comment on attachment 9010136 [details]
Bug 1490950: Define aboutdebugging in script tag on html. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9010136 - Flags: review+
Attachment #9010136 - Attachment description: Bug 1490950: Change destroy() to synchronized function. r=jdescottes → Bug 1490950: Define aboutdebugging in script tag on html. r=jdescottes
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66041721e70b
Define aboutdebugging in script tag on html. r=jdescottes
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/66041721e70b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.