1490950 - [remote-dbg-next] Investigate why order matters when destroying about:debugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1489219.

In the destroy method of aboutdebugging-new/aboutdebugging.js : 

  async destroy() {
    L10nRegistry.removeSource("aboutdebugging");
    removeNetworkLocationsObserver(this.onNetworkLocationsUpdated);
    await this.actions.disconnectRuntime();
    setDebugTargetCollapsibilities(this.store.getState().ui.debugTargetCollapsibilities);
    unmountComponentAtNode(this.mount);
  },

The call to `removeNetworkLocationsObserver` absolutely has to happen before `await this.actions.disconnectRuntime()`. We should check why this is and if it can be avoided.

Comment 1

[Daisuke Akatsuka (:daisuke)]

I am making a test bug 1489221 though, `setDebugTargetCollapsibilities` is not called at all since it looks like `await this.actions.disconnectRuntime()` waits forever.
I'm not sure but `this.actions.disconnectRuntime()` does not return Promise??
Will investigate this one.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1490950: Define aboutdebugging in script tag on html. r=jdescottes

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 9010136 [details]
Bug 1490950: Define aboutdebugging in script tag on html. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66041721e70b
Define aboutdebugging in script tag on html. r=jdescottes

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/66041721e70b