Improve code coverage speed in removing useless files at compile time
Categories
(Testing :: Code Coverage, enhancement)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: calixte, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
Right now, we remove useless files such ones in /usr/include at post-process stage. It would increase speed and reduce gcno/gcda file size to do that at compile time.
|
Reporter | |
Comment 1•6 years ago
|
||
A patch is waiting for a review in LLVM: https://reviews.llvm.org/D52033
|
Assignee | |
Comment 2•5 years ago
|
||
I need to verify this actually works.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Here's the try build, https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbaa03d56518c68b1eeb631fa2315d4adcff8d5a, I'll download it locally and test that the VS stuff is not generated.
And I will morph this bug into doing it for Windows and will open a separate bug for Linux (for Linux we need to switch to Clang first).
|
|
Reporter | |
Comment 4•5 years ago
|
||
Comment on attachment 9040356 [details] [diff] [review] Patch Review of attachment 9040356 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
Depends on D18510
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a536e231f838 Set CFLAGS and CXXFLAGS in toolchain.configure for coverage builds. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/f1cdf858b026 Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium
|
||
Updated•5 years ago
|
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a536e231f838
https://hg.mozilla.org/mozilla-central/rev/f1cdf858b026
|
||
Comment 10•5 years ago
•
|
||
:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?
EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?
|
|
Assignee | |
Comment 11•5 years ago
|
||
(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #10)
:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?
EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?
This is not really a workaround, when code coverage is enabled we have to add "--coverage" to CFLAGS and CXXFLAGS.
Description
•