1491004 - Improve code coverage speed in removing useless files at compile time

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Calixte Denizet (:calixte)]

Right now, we remove useless files such ones in /usr/include at post-process stage.
It would increase speed and reduce gcno/gcda file size to do that at compile time.

Comment 1

[Calixte Denizet (:calixte)]

A patch is waiting for a review in LLVM:
https://reviews.llvm.org/D52033

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

I need to verify this actually works.

Comment 3

[Marco Castelluccio [:marco]]

Here's the try build, https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbaa03d56518c68b1eeb631fa2315d4adcff8d5a, I'll download it locally and test that the VS stuff is not generated.

And I will morph this bug into doing it for Windows and will open a separate bug for Linux (for Linux we need to switch to Clang first).

Comment 4

[Calixte Denizet (:calixte)]

Comment on attachment 9040356 [details] [diff] [review]
Patch

Review of attachment 9040356 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Bug 1491004 - Set CFLAGS and CXXFLAGS in toolchain.configure for coverage builds. r=chmanchester

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Bug 1491004 - Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium

Depends on D18510

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a536e231f838
Set CFLAGS and CXXFLAGS in toolchain.configure for coverage builds. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/f1cdf858b026
Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a536e231f838
https://hg.mozilla.org/mozilla-central/rev/f1cdf858b026

Comment 10

[Edwin Takahashi (:egao | infrequent contributor)]

:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?

EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?

Comment 11

[Marco Castelluccio [:marco]]

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #10)

:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?

EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?

This is not really a workaround, when code coverage is enabled we have to add "--coverage" to CFLAGS and CXXFLAGS.