1647839 - clang-11 no longer supports -coverage-no-function-names-in-data

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[(Away)]

The flag was removed in llvmorg-11-init-14426-g13a633b438b.

Marco, is this something that we could just gate on c_compiler.version < '11.0.0' in coverage_cflags or is there a deeper issue involved?

Comment 1

[(Away)]

Hm, Bugzilla didn't save my needinfo flag for some reason...

Comment 2

[Marco Castelluccio [:marco]]

(In reply to :dmajor from comment #0)

The flag was removed in llvmorg-11-init-14426-g13a633b438b.

Marco, is this something that we could just gate on c_compiler.version < '11.0.0' in coverage_cflags or is there a deeper issue involved?

That should be enough, the option was removed as it is now the default behavior.

Comment 3

[(Away)]

Attachment: Don't pass -coverage-no-function-names-in-data in clang 11

In clang-11 the flag's behavior became the default, and in fact the flag is no longer accepted so we get an unrecognized option error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fabb57a60747
Don't pass -coverage-no-function-names-in-data in clang 11 r=marco

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fabb57a60747