Closed Bug 1491209 Opened 6 years ago Closed 6 years ago

Remove hardcoded lastFallbackLocale from requestedLocales

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Back in bug 1414872 (and bug 1414390) we added the lastFallbackLocale to RequestedLocales.

This was a safety-check to keep us closer to the behavior of the old system and ensure that we always have it in requested.

Now, we don't use GetRequestedLocales almost anywhere in the code, except of couple places where the fallback doesn't matter.

In fact, we start having pieces of code that should not have this fallback hardcoded, like the language selector.

Since the real value is that the lastFallback is still added to the result of negotiation (AppLocales), we can remove it from the requested and keep the requested actually match what user requested only.
Assignee: nobody → gandalf
Blocks: 1346877
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 9009012 [details]
Bug 1491209 - Do not inject last fallback locale into requested locales. r=jfkthame

Jonathan Kew (:jfkthame) has approved the revision.
Attachment #9009012 - Flags: review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ea01a4e6846
Do not inject last fallback locale into requested locales. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/3ea01a4e6846
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: