Status

()

P3
normal
ASSIGNED
2 years ago
6 months ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

(Depends on: 4 bugs)

Firefox Tracking Flags

(Not tracked)

Details

There's a shrinking number of changes that we need to add to LocaleService before it can be considered stable.

I'd like to use this tracking bug to track those and once they're all resolved, I'd like to clean up docs and tests.
(Assignee)

Updated

2 years ago
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Depends on: 1347002
(Assignee)

Updated

2 years ago
Depends on: 1339650
(Assignee)

Updated

2 years ago
Depends on: 1347272
(Assignee)

Updated

2 years ago
Blocks: 1347306
(Assignee)

Updated

2 years ago
Depends on: 1348042
(Assignee)

Updated

2 years ago
Depends on: 1349375
(Assignee)

Updated

2 years ago
Depends on: 1349377
(Assignee)

Comment 1

2 years ago
 - look at what functions could can take const.
(Assignee)

Comment 2

2 years ago
 - should switch to artifical locales in tests to ensure that real test env. locales don't create false positives.
(Assignee)

Comment 3

2 years ago
:jfkthame brought up a point in bug 1346616 that we should return `undefined` for missing value in singular calls like getRequestedLocale, getAppLocaleAsLangTag, getAppLocaleAsBCP47.

While my hope is that we'll move away from the singular forms overall, it would be good to make sure that we don't treat the edge case scenarios (when request locale is not set) the same way as if it's set to an empty string.

I'll try to do this in this bug, add tests and also test extensively if any use case of the API breaks.
(Assignee)

Comment 4

2 years ago
(also, probably the same should happen with OSIPreferences.systemLocale).
(Assignee)

Comment 5

2 years ago
As :qDot pointed out in bug 1348042 comment 20, we may want to look into splitting LocaleService into Client/Server files and classes that inherit from a base class.

I'd prefer to do that as part of this bug so that it's not combined with functional changes.
(Assignee)

Updated

2 years ago
Depends on: 1358628
(Assignee)

Updated

2 years ago
Depends on: 1358653
While you're splitting out functionality in LocaleService, could you also throw main thread checks in on GetInstance and all public service functions? There's a ton of code in there that will crash anyways if anything happens off the main thread (preferences, clearonshutdown, etc), but it's just nice to fail early if we can.
(Assignee)

Comment 7

2 years ago
Jonathan, what's your take on splitting LocaleService into LocaleServiceBase, LocaleServiceClient and LocaleServiceParent?
Flags: needinfo?(jfkthame)
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7)
> Jonathan, what's your take on splitting LocaleService into
> LocaleServiceBase, LocaleServiceClient and LocaleServiceParent?

I don't feel strongly about it, but I do think it'd probably be good for long-term readability and maintenance.
Flags: needinfo?(jfkthame)
(Assignee)

Updated

2 years ago
Summary: Finalize LanguageService → Finalize LocaleService
(Assignee)

Updated

2 years ago
Depends on: 1352343
(Assignee)

Updated

a year ago
Depends on: 1410736
(Assignee)

Updated

a year ago
Depends on: 1414390
(Assignee)

Updated

a year ago
Depends on: 1414878
Priority: -- → P3
(Assignee)

Updated

a year ago
Depends on: 1418771
(Assignee)

Updated

a year ago
Depends on: 1424953
(Assignee)

Updated

a year ago
Depends on: 1438687
(Assignee)

Updated

a year ago
Depends on: 1440969
(Assignee)

Updated

a year ago
Depends on: 1448891
(Assignee)

Updated

6 months ago
Depends on: 1491209
(Assignee)

Updated

6 months ago
Depends on: 1491394
You need to log in before you can comment on or make changes to this bug.