1491221 - Oculus Go has no `EXT_shader_texture_lod` , but getExtension( 'EXT_shader_texture_lod' ) returns true.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P3)

Description

[Daosheng Mu[:daoshengmu]]

We notice three.js `EXT_shader_texture_lod` examples are not run properly [1]. After printing the GL extensions from Oculus Go [2] and find there is no `EXT_shader_texture_lod`. We should give a workaround for gl->vendor() is Qualcomm and gl-render() is AdrenoTM530.

[1] https://github.com/MozillaReality/FirefoxReality/issues/461
[2] https://github.com/MozillaReality/FirefoxReality/issues/461#issuecomment-419785619

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1491221 - Mark EXT_shader_texture_lod extension unsupported for AdrenoTM530.

MozReview-Commit-ID: DRbbukaUwKl

Comment 2

[Daosheng Mu[:daoshengmu]]

Waiting for the try result, https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca9a3914f110271f18dcd3c12b09d8da7569cf0b

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1491221 - Mark EXT_shader_texture_lod feature unsupported for AdrenoTM530.

MozReview-Commit-ID: 4i6rbRV7ZX5

Comment 4

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=81229d5b9bee9ca4db1ef7a1e2322e84deda3065

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Daosheng Mu[:daoshengmu] from comment #0)
> We notice three.js `EXT_shader_texture_lod` examples are not run properly
> [1]. After printing the GL extensions from Oculus Go [2] and find there is
> no `EXT_shader_texture_lod`. We should give a workaround for gl->vendor() is
> Qualcomm and gl-render() is AdrenoTM530.
> 
> [1] https://github.com/MozillaReality/FirefoxReality/issues/461
> [2]
> https://github.com/MozillaReality/FirefoxReality/issues/461#issuecomment-
> 419785619

We only enable it if GL3 || ES3 || ARB_shader_texture_lod || EXT_shader_texture_lod, so if the driver doesn't expose it, we shouldn't be enabling it. Can you post the about:support graphics section from the affected device?

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: about:support:Graphics from Oculus Go

Please take a look at the attachment. It looks like no ARB_shader_texture_lod || EXT_shader_texture_lod, but it is indeed OpenGL ES 3.2.

Comment 7

[Kelsey Gilbert [:jgilbert]]

So ES3+ definitely has textureLod(), but ANGLE's translator might be messing up here, since there's no indication to it that we're targetting ES3 and not ES2. I'm trying to figure out what their approach is, but I'm betting they implicitly only use ES3 if we're targetting WebGL2, which is wrong. If that's the case, the fix here is to request an ES2 context for WebGL1.

Comment 8

[Daosheng Mu[:daoshengmu]]

It looks like this device has asked OpenGL ES2 for WebGL 1.


The call stack is as below:

https://searchfox.org/mozilla-central/rev/881a3c5664ede5e08ee986d76433bc5c4b5680e6/gfx/gl/GLContextProviderEGL.cpp#972

out->AppendElement(LOCAL_EGL_OPENGL_ES2_BIT);


mozilla::gl::FillContextAttribs(bool, bool, bool, bool, bool, nsTArray<int>*) GLContextProviderEGL.cpp:955
mozilla::gl::ChooseConfig(mozilla::gl::GLLibraryEGL*, mozilla::gl::CreateContextFlags, ...) GLContextProviderEGL.cpp:1032
mozilla::gl::GLContextEGL::CreateEGLPBufferOffscreenContext(mozilla::gl::CreateContextFlags, ...) GLContextProviderEGL.cpp:1074
mozilla::gl::GLContextProviderEGL::CreateOffscreen(...) GLContextProviderEGL.cpp:1170
mozilla::WebGLContext::CreateAndInitGL()

Comment 9

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1491221 - Mark EXT_shader_texture_lod feature unsupported for OpenGL ES3 and above.

MozReview-Commit-ID: G51cg7pqvBb

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9011990 [details]
Bug 1491221 - Mark EXT_shader_texture_lod feature unsupported for OpenGL ES3 and above.

Jeff Gilbert [:jgilbert] has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfe90e5953d9
Mark EXT_shader_texture_lod feature unsupported for OpenGL ES3 and above. r=jgilbert

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cfe90e5953d9