1524804 - (webgl1-es2) WebGL 1 requires ES2 (not ES3) for some extensions

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Description

[Kelsey Gilbert [:jgilbert]]

We ask for ES2 on Android, but drivers often give us ES3, which is unfortunately legal.
We might be able to manually select an EGLConfig that supports ES2 but not ES3, and get ES2 that way.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Specifically, this is required because ANGLE can't translate ESSL1+extensions shaders into ESSL3. Otherwise we'd prefer ES3 everywhere.

Comment 3

[Kelsey Gilbert [:jgilbert]]

It doesn't seem possible to request ES2 instead of ES3 on Android:
https://jdashg.github.io/misc/misc.html#gles2-on-android

I don’t see a way to get ES2 if the device offers ES3. The only thing I can think of is to manually search for EGLConfigs where either RENDERABLE_TYPE or CONFORMANT is missing the EGL_OPENGL_ES3_BIT bit. However, I dumped the configs in Fennec, and they’re all the same for those[.]

EGL_RENDERABLE_TYPE: 0x45 (EGL_OPENGL_ES_BIT | EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT)
EGL_CONFORMANT: 0x45 (EGL_OPENGL_ES_BIT | EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT)

Comment 4

[Kelsey Gilbert [:jgilbert]]

We need to mark affected extensions as disabled on ES3.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1524804 - Some webglsl1/essl1 exts can't be implemented on es3 contexts.

MozReview-Commit-ID: DoyN2kNlL01

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b2c90c9792
Some webglsl1/essl1 exts can't be implemented on es3 contexts. r=lsalzman

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e0b2c90c9792