1491245 - Port formatValue (i.e. URL highlighting) from urlbarBindings.xml to UrlbarInput.jsm

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Dão Gottwald [:dao]]

Bug 1477985 added a stub for this; we need to port the full implementation from urlbarBindings.xml.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r?standard8

Comment 2

[Dão Gottwald [:dao]]

I had hoped that phabricator would make it easier to review the urlbarBindings.xml -> UrlbarValueFormatter.jsm part, but arguably it makes it harder...

Comment 3

[Dão Gottwald [:dao]]

Attachment: hg diff browser/components/urlbar/UrlbarValueFormatter.jsm -w

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r?standard8

Comment 5

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c211a5389b7c81ea79961919474496faa3e7fd70

Comment 6

[Dão Gottwald [:dao]]

Tests for this are browser_urlHighlight.js, browser_urlbarHighlightSearchAlias.js, and maybe a few others.

Comment 7

[Dão Gottwald [:dao]]

Attachment: hg diff browser/components/urlbar/UrlbarValueFormatter.jsm -w

Comment 8

[Dão Gottwald [:dao]]

Attachment: hg diff browser/components/urlbar/UrlbarValueFormatter.jsm -w

Comment 9

[Dão Gottwald [:dao]]

Attachment: Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r?standard8

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4d2c14d8fa5
Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r=Standard8

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a4d2c14d8fa5