Closed Bug 1491245 Opened Last year Closed Last year

Port formatValue (i.e. URL highlighting) from urlbarBindings.xml to UrlbarInput.jsm

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 4 obsolete files)

Bug 1477985 added a stub for this; we need to port the full implementation from urlbarBindings.xml.
Depends on: 1491255
Summary: Port formatValue from urlbarBindings.xml to UrlbarInput.jsm → Port formatValue (i.e. URL highlighting) from urlbarBindings.xml to UrlbarInput.jsm
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
I had hoped that phabricator would make it easier to review the urlbarBindings.xml -> UrlbarValueFormatter.jsm part, but arguably it makes it harder...
Attachment #9012908 - Attachment is obsolete: true
Blocks: war-on-xbl
Tests for this are browser_urlHighlight.js, browser_urlbarHighlightSearchAlias.js, and maybe a few others.
Attachment #9012912 - Attachment is obsolete: true
Attachment #9013716 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d2c14d8fa5
Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/a4d2c14d8fa5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Blocks: 1496152
Depends on: 1496703
Depends on: 1497464
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.