Closed Bug 1491245 Opened Last year Closed Last year
Value (i .e . URL highlighting) from urlbar Bindings .xml to Urlbar Input .jsm
135.79 KB, patch
|Details | Diff | Splinter Review|
Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r?standard8
46 bytes, text/x-phabricator-request
|Details | Review|
Bug 1477985 added a stub for this; we need to port the full implementation from urlbarBindings.xml.
Summary: Port formatValue from urlbarBindings.xml to UrlbarInput.jsm → Port formatValue (i.e. URL highlighting) from urlbarBindings.xml to UrlbarInput.jsm
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
I had hoped that phabricator would make it easier to review the urlbarBindings.xml -> UrlbarValueFormatter.jsm part, but arguably it makes it harder...
Tests for this are browser_urlHighlight.js, browser_urlbarHighlightSearchAlias.js, and maybe a few others.
Attachment #9013716 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a4d2c14d8fa5 Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r=Standard8
You need to log in before you can comment on or make changes to this bug.