1491255 - Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1491252 +++

See trimValue in urlbarBindings.xml.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

This makes browser/base/content/test/urlbar/browser_urlbarTrimURLs.js pass

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

test_UrlbarInput_unit.js fixed

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 9011756 [details] [diff] [review]
patch

Review of attachment 9011756 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/urlbar/UrlbarPrefs.jsm
@@ +170,5 @@
>     * Returns the value for the preference with the given name.
>     *
>     * @param {string} pref
>     *        The name of the preference to get.
> +   * @returns {string} The preference value.

Digging into this, I think we currently return strings, arrays, booleans and integers. So we could make the value `{string|array|boolean|number}`, but I'm wonder if it is just better to go with `{*}` - basically admit it could be almost anything.

(same with the changes below).

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cb351adc7d3
Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7a945fc6271
Backed out changeset 8cb351adc7d3 for failing test verify on browser_urlbarTrimURLs.js

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch v3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/184a229a8cc4
Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/184a229a8cc4