1491391 - Show missing field errors under missing field pickers

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Eric Pang [:epang] UX]

Create specs that display an error state when there's missing fields.

Comment 1

[Eric Pang [:epang] UX]

Attachment: missing-fields-error.png

Screens from spec for missing fields error

Link to ixd https://mozilla.invisionapp.com/d/main#/console/13170472/275361836/preview

Comment 2

[Matthew N. [:MattN]]

Marco, please stop demoting bugs to reserve when they have been deemed as required for the MVP.

Comment 3

[Marco Mucci [:MarcoM]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #2)
> Marco, please stop demoting bugs to reserve when they have been deemed as
> required for the MVP.

Send me the list of new MVP.

Comment 4

[Matthew N. [:MattN]]

This one is now out of M3 as we will use the FTU so won't have missing fields when the picker is shown.

Comment 5

[Matthew N. [:MattN]]

Eng. implemented this.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Missing field errors are displayed now in the pickers. However, there are some differences worth mentioning:

 - If the City is missing, it is labeled as "Address Level2 Missing"
 - Phone Number missing is shown as "Tel Missing"

Check screenshots: https://imgur.com/a/HbxL24L

Moreover, if the State is missing there will be no missing field error displayed for it. My guess is that it is the aftermath for Bug 1497225. If the State field is not displayed as required due to field changes, as explained in the mentioned bug, it will also not trigger its own field error.  Not entirely sure if my statement is correct, just a wild guess.

Comment 7

[Eric Pang [:epang] UX]

redirecting to Matt

Comment 8

[Matthew N. [:MattN]]

(In reply to Timea Babos from comment #6)
> Missing field errors are displayed now in the pickers. However, there are
> some differences worth mentioning:
> 
>  - If the City is missing, it is labeled as "Address Level2 Missing"
>  - Phone Number missing is shown as "Tel Missing"
> 
> Check screenshots: https://imgur.com/a/HbxL24L

That is already filed as bug 1490816.

> Moreover, if the State is missing there will be no missing field error
> displayed for it. My guess is that it is the aftermath for Bug 1497225. If
> the State field is not displayed as required due to field changes, as
> explained in the mentioned bug, it will also not trigger its own field
> error.  Not entirely sure if my statement is correct, just a wild guess.

Yeah, that is related to bug 1497225 and should be fixed by bug 1481481.

Comment 9

[Matthew N. [:MattN]]

So we don't need any new bugs for these issues

Comment 10

[Timea Cernea [:tbabos][inactive]]

Thanks Matt!

Since the issues are already addressed, will close this one as Verified - Fixed on all OS.