1491536 - Remove obsolete footer image CSS

Status: RESOLVED FIXED

(WebExtensions :: Themes, enhancement)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/browser/base/content/browser.css#509-515

Needs to be removed.

Comment 1

[Tim Nguyen :ntim]

Shivam, are you interested in working on this ?

Comment 2

[Shivam Singhal [ :championshuttler ]]

@ntim yeah , i would love to work on it :)

Comment 3

[Tim Nguyen :ntim]

Great!

Comment 4

[Shivam Singhal [ :championshuttler ]]

@ntim , i need some help , i have some doubts in mercurial . like so now that PR is merged. do i need to create a another branch for this bug, and if yes then how to do that? also how to pull the new changes to my cloned repository on my laptop. I never used mercurial and arc before. . Used git till now for amo and other projects.


Thanks
Shivam

Comment 5

[Tim Nguyen :ntim]

(In reply to Shivam Singhal [:championshuttler] from comment #4)
> @ntim , i need some help , i have some doubts in mercurial . like so now
> that PR is merged. do i need to create a another branch for this bug, and if
> yes then how to do that? also how to pull the new changes to my cloned
> repository on my laptop. I never used mercurial and arc before. . Used git
> till now for amo and other projects.
> 
> 
> Thanks
> Shivam

You can do `hg pull` (similar to `git fetch`) to pull the latest code. Once you've done that, you can do `hg up central` (similar to `git checkout central`). Once you've done that, you can do your changes and then commit them.

Comment 6

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1491536 - Remove obsolete footer image CSS. r=ntim

Removed obsolete footer image css

Comment 7

[Shivam Singhal [ :championshuttler ]]

(In reply to Tim Nguyen :ntim from comment #5)

> You can do `hg pull` (similar to `git fetch`) to pull the latest code. Once
> you've done that, you can do `hg up central` (similar to `git checkout
> central`). Once you've done that, you can do your changes and then commit
> them.


Works perfectly , thanks for the help , also did `hg update` to update to the tip of repo.

Thanks

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 9009400 [details]
Bug 1491536 - Remove obsolete footer image CSS. r=ntim

Tim Nguyen :ntim has approved the revision.

Comment 9

[Tim Nguyen :ntim]

(In reply to Shivam Singhal [:championshuttler] from comment #7)
> 
> Works perfectly , thanks for the help , also did `hg update` to update to
> the tip of repo.
> 
> Thanks

`hg up` is the same thing as `hg update` :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c879e092971
Remove obsolete footer image CSS. r=ntim

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0c879e092971

Comment 12

[Vlad Jiman]

Will manual testing be required on this bug? if so, please specify some info on how to validate. Otherwise please set the qe-verify- flag. Thanks!