Remove obsolete footer image CSS

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: ntim, Assigned: championshuttler, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla64
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Shivam, are you interested in working on this ?
Flags: needinfo?(shivams2799)
@ntim yeah , i would love to work on it :)
Flags: needinfo?(shivams2799) → needinfo?(ntim.bugs)
Great!
Assignee: nobody → shivams2799
Flags: needinfo?(ntim.bugs)
@ntim , i need some help , i have some doubts in mercurial . like so now that PR is merged. do i need to create a another branch for this bug, and if yes then how to do that? also how to pull the new changes to my cloned repository on my laptop. I never used mercurial and arc before. . Used git till now for amo and other projects.


Thanks
Shivam
Flags: needinfo?(ntim.bugs)
(In reply to Shivam Singhal [:championshuttler] from comment #4)
> @ntim , i need some help , i have some doubts in mercurial . like so now
> that PR is merged. do i need to create a another branch for this bug, and if
> yes then how to do that? also how to pull the new changes to my cloned
> repository on my laptop. I never used mercurial and arc before. . Used git
> till now for amo and other projects.
> 
> 
> Thanks
> Shivam

You can do `hg pull` (similar to `git fetch`) to pull the latest code. Once you've done that, you can do `hg up central` (similar to `git checkout central`). Once you've done that, you can do your changes and then commit them.
Flags: needinfo?(ntim.bugs)
Removed obsolete footer image css
(In reply to Tim Nguyen :ntim from comment #5)

> You can do `hg pull` (similar to `git fetch`) to pull the latest code. Once
> you've done that, you can do `hg up central` (similar to `git checkout
> central`). Once you've done that, you can do your changes and then commit
> them.


Works perfectly , thanks for the help , also did `hg update` to update to the tip of repo.

Thanks
Attachment #9009400 - Attachment description: Bug 1491536- Remove obsolete footer image CSS → Bug 1491536- Remove obsolete footer image CSS. r=ntim
Comment on attachment 9009400 [details]
Bug 1491536 - Remove obsolete footer image CSS. r=ntim

Tim Nguyen :ntim has approved the revision.
Attachment #9009400 - Flags: review+
Attachment #9009400 - Attachment description: Bug 1491536- Remove obsolete footer image CSS. r=ntim → Bug 1491536 - Remove obsolete footer image CSS. r=ntim
(In reply to Shivam Singhal [:championshuttler] from comment #7)
> 
> Works perfectly , thanks for the help , also did `hg update` to update to
> the tip of repo.
> 
> Thanks

`hg up` is the same thing as `hg update` :)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0c879e092971
Remove obsolete footer image CSS. r=ntim
https://hg.mozilla.org/mozilla-central/rev/0c879e092971
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Will manual testing be required on this bug? if so, please specify some info on how to validate. Otherwise please set the qe-verify- flag. Thanks!
Flags: needinfo?(shivams2799)
Flags: qe-verify-
Flags: needinfo?(shivams2799)
You need to log in before you can comment on or make changes to this bug.