Remove obsolete footerURL code

VERIFIED FIXED in Firefox 64

Status

P3
normal
VERIFIED FIXED
9 months ago
6 months ago

People

(Reporter: ntim, Assigned: championshuttler, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

unspecified
mozilla64
good-first-bug
Dependency tree / graph

Firefox Tracking Flags

(firefox64 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
footerURL is not displayed anywhere in Firefox, let's remove that.
Please tell more about this.
How can I work on this?
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 2

9 months ago
Here's the code you'll need to remove:
https://dxr.mozilla.org/mozilla-central/search?q=footerURL&case=false&regexp=false&path=toolkit
Flags: needinfo?(ntim.bugs)
Assignee: nobody → 1991manish.kumar
Priority: -- → P3
what about these kinds of lines?
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm#26

What to do with 'footerURL' here and how can I test?
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 4

9 months ago
In that specific case, you should remove `"footerURL", ` from the array.

> how can I test?

Just make sure switching themes in the customize mode still works (Menu > Customize > Themes).
Flags: needinfo?(ntim.bugs)
Assignee: 1991manish.kumar → nobody
(Reporter)

Updated

7 months ago
Mentor: ntim.bugs
Keywords: good-first-bug
Hi, i would like to work on this issue,
(Reporter)

Comment 6

7 months ago
(In reply to Shivam Singhal [:championshuttler] from comment #5)
> Hi, i would like to work on this issue,

In case you haven't, please set up a development environment (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction ). Once that's done, feel free to remove the code from comment 2, and attach a patch once you're done.

Please let me know if you need help.
Assignee: nobody → shivams2799
Removing footerURL code , few of the lines are left , i am not sure how to delete them and what to use instead of them there.
(Reporter)

Comment 8

6 months ago
Comment on attachment 9008838 [details]
Bug 1471305 - Remove obsolete footerURL code.

Tim Nguyen :ntim has approved the revision.
Attachment #9008838 - Flags: review+

Comment 9

6 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e60665194092
Remove obsolete footerURL code. r=ntim

Comment 10

6 months ago
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bb04fb52dd7
Backed out changeset e60665194092 for eslint failure at extensions/internal/LightweightThemeImageOptimizer.jsm on a CLOSED TREE
Hi ntim , can you tell me what happened, did the commit revert now?
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 12

6 months ago
(In reply to Shivam Singhal [:championshuttler] from comment #11)
> Hi ntim , can you tell me what happened, did the commit revert now?

Yes, the commit was reverted. There was a ESLint failure: https://treeherder.mozilla.org/logviewer.html#?job_id=199355439&repo=autoland&lineNumber=66

Your patch made ORIGIN_BOTTOM_LEFT unused, so you'll need to remove that variable definition: https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/toolkit/mozapps/extensions/internal/LightweightThemeImageOptimizer.jsm#18

Once you've done that, the patch should be good to go.
Flags: needinfo?(ntim.bugs)

Comment 13

6 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/abcfb507d1e9
Remove obsolete footerURL code. r=ntim

Comment 14

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/abcfb507d1e9
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1491529
(Reporter)

Updated

6 months ago
Depends on: 1491536

Comment 15

6 months ago
Verified according to comment #4 using Nightly 64.0a1 (2018-09-16) running on Windows 10 x64, no issues were found with the themes on the new version.

Updated

6 months ago
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
You need to log in before you can comment on or make changes to this bug.