footerURL is not displayed anywhere in Firefox, let's remove that.
Please tell more about this. How can I work on this?
Here's the code you'll need to remove: https://dxr.mozilla.org/mozilla-central/search?q=footerURL&case=false®exp=false&path=toolkit
Assignee: nobody → 1991manish.kumar
what about these kinds of lines? https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm#26 What to do with 'footerURL' here and how can I test?
In that specific case, you should remove `"footerURL", ` from the array. > how can I test? Just make sure switching themes in the customize mode still works (Menu > Customize > Themes).
Assignee: 1991manish.kumar → nobody
Hi, i would like to work on this issue,
(In reply to Shivam Singhal [:championshuttler] from comment #5) > Hi, i would like to work on this issue, In case you haven't, please set up a development environment (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction ). Once that's done, feel free to remove the code from comment 2, and attach a patch once you're done. Please let me know if you need help.
Removing footerURL code , few of the lines are left , i am not sure how to delete them and what to use instead of them there.
Comment on attachment 9008838 [details] Bug 1471305 - Remove obsolete footerURL code. Tim Nguyen :ntim has approved the revision.
Attachment #9008838 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e60665194092 Remove obsolete footerURL code. r=ntim
Backout by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9bb04fb52dd7 Backed out changeset e60665194092 for eslint failure at extensions/internal/LightweightThemeImageOptimizer.jsm on a CLOSED TREE
Hi ntim , can you tell me what happened, did the commit revert now?
(In reply to Shivam Singhal [:championshuttler] from comment #11) > Hi ntim , can you tell me what happened, did the commit revert now? Yes, the commit was reverted. There was a ESLint failure: https://treeherder.mozilla.org/logviewer.html#?job_id=199355439&repo=autoland&lineNumber=66 Your patch made ORIGIN_BOTTOM_LEFT unused, so you'll need to remove that variable definition: https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/toolkit/mozapps/extensions/internal/LightweightThemeImageOptimizer.jsm#18 Once you've done that, the patch should be good to go.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/abcfb507d1e9 Remove obsolete footerURL code. r=ntim
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Verified according to comment #4 using Nightly 64.0a1 (2018-09-16) running on Windows 10 x64, no issues were found with the themes on the new version.
You need to log in before you can comment on or make changes to this bug.