1491601 - TypeError: frame is undefined subdialogs.js:355:5, on resizing a preferences subdialogue, like about:config

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jorg K (CEST = GMT+2)]

I came here from bug 1491562 comment #8. Already broken in TB 60 ESR.

Comment 1

[Jorg K (CEST = GMT+2)]

We should look at this one one day.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1491601-subdialogs-undefined-1.diff

I've got this.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1491601-subdialog.patch

You beat me. I synchronized subdialogs.js with the m-c version.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9015103 [details] [diff] [review]
1491601-subdialog.patch

Review of attachment 9015103 [details] [diff] [review]:
-----------------------------------------------------------------

Geoff and Richard, I prefer to keep in sync with FF as much as we can here. Apart from one hunk, this seems reasonable. Could you please cast an eye onto it. Thanks.

r+ with the comment addressed.

::: mail/components/preferences/subdialogs.js
@@ +276,5 @@
> +    //
> +    // In that case, we expect them to define a Promise which will delay measuring
> +    // until the promise is fulfilled.
> +    if (aEvent.target.contentDocument.mozSubdialogReady) {
> +      await aEvent.target.contentDocument.mozSubdialogReady;

I tried this the other day when looking for the missing Fluent labels and that doesn't work, so we can't port it.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9015102 [details] [diff] [review]
1491601-subdialogs-undefined-1.diff

Thanks, I prefer the other patch if you approve.

Comment 6

[Jorg K (CEST = GMT+2)]

Maybe we can use the "small" solution for TB 60 since keeping in sync is not required there.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1491601-subdialog.patch

Addressed comment. I saw no difference with or without this hunk, especially in the Fonts dialog.

Carrying over the r+ and f? from previous patch but waiting for the check-in needed.

Comment 8

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #7)
> Addressed comment. I saw no difference with or without this hunk, ...
When operating the language alternatives menu, you get this in the error console (and the debug windows if you have one):
TypeError: aEvent.target.contentDocument is undefined; can't access its "mozSubdialogReady" property - subdialogs.js:279:5

As I said, I saw this the other day when I was looking for the missing Fluent strings.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60.3 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/147e5e18d4ca65efd9f186a9067199f784474210 (Geoff's patch)

Comment 10

[Jorg K (CEST = GMT+2)]

Confirmed working in ESR build.

Comment 11

[Geoff Lankow (:darktrojan)]

Might as well assign this to somebody who made a decent effort. :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eaaaf728d1d6
Synchronize subdialog.js with M-C to fix JS TypeError. r=jorgk

Comment 13

[Jorg K (CEST = GMT+2)]

TB 63.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/04ee89d424ba (Geoff's patch)