Closed Bug 1491784 Opened 4 years ago Closed 4 years ago

_handleTabSelect accesses selectedItem too often


(Firefox :: Tabbed Browser, enhancement, P3)




Firefox 64
Tracking Status
firefox64 --- fixed


(Reporter: dao, Assigned: maggus.staab)



(Keywords: perf)


(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1491286 +++

The selectedItem getter is kind of expensive, we should only access it once in _handleTabSelect:,402

See the patch in bug 1491286 for how to fix this.
I will send a patch for this.
I guess I did not get everything right, but the diff is on phabricator now:
Flags: needinfo?(dao+bmo)
Comment on attachment 9010365 [details]
Bug 1491784 - Access selectedItem only once in _handleTabSelect. r=dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9010365 - Flags: review+
Attachment 9010365 [details] looks good. You can abandon attachment 9010368 [details].

Gonna land this in a bit.

Assignee: nobody → maggus.staab
Flags: needinfo?(dao+bmo)
sorry for the double post. I am new to hg and mixed some commands up, because I am used to git and it seems the commands are not equivalent for some parts.
Pushed by
Access selectedItem only once in _handleTabSelect. r=dao
Attachment #9010368 - Attachment is obsolete: true
(In reply to Dão Gottwald [::dao] from comment #6)
> You can abandon attachment 9010368 [details]

just marked the attachment as obsolete. didn't found a button or similar to close the corresponding diff in phabricator
Flags: needinfo?(dao+bmo)
Yeah, no clue how to do that in phabricator. I guess you can just leave the diff open.
Flags: needinfo?(dao+bmo)
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.