1491786 - _notifyBackgroundTab accesses selectedItem too often

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1491286 +++

The selectedItem getter is kind of expensive, we should only access it once in _notifyBackgroundTab:

https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/browser/base/content/tabbrowser.xml#766-767

See the patch in bug 1491286 for how to fix this.

Comment 1

[maggus.staab]

is this a good first bug I could work on?

Comment 2

[Dão Gottwald [:dao]]

Sure!

Comment 3

[maggus.staab]

Attachment: patch.diff

please find my patch enclosed

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9010353 [details] [diff] [review]
patch.diff

Hm, this looks good at a first glance, but when I try to apply the patch, I get:

patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

Did you manually edit the patch file?

Comment 5

[maggus.staab]

I did not manually fiddle with it. But since I got arcanist running I could try to push the patch to phabricator instead.

I will try that.

Comment 6

[maggus.staab]

Attachment: Bug 1491786 - Access selectedItem only once in _notifyBackgroundTab. r=dao

Comment 7

[maggus.staab]

got a phabricator diff up, after a lot or research.

thx to the cool people in the #phabricator irc channel (especially imadueme and mcote)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90b5ea4678b3
Access selectedItem only once in _notifyBackgroundTab. r=dao

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9010427 [details]
Bug 1491786 - Access selectedItem only once in _notifyBackgroundTab. r=dao

Dão Gottwald [::dao] has approved the revision.

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/90b5ea4678b3