1491846 - GetFrameLoader inside child objects vtbls could not be resolved by linker in mingw-clang build

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1491846 GetFrameLoader inside child objects vtbls could not be resolved by linker. It looks like a clang bug, but requires closer look. I worked around it by having explicit forwards. r=Alex_Gaynor

Comment 2

[Tom Ritter [:tjr]]

Without this patch we get these errors:

> lld-link: error: undefined symbol: __ZThn88_N22nsObjectLoadingContent14GetFrameLoaderEv
> >>> referenced by ../../dom/html/Unified_cpp_dom_html0.o:(__ZTVN7mozilla3dom16HTMLEmbedElementE)
> lld-link: error: undefined symbol: __ZThn76_N25nsGenericHTMLFrameElement14GetFrameLoaderEv
> >>> referenced by ../../dom/html/Unified_cpp_dom_html1.o:(__ZTVN7mozilla3dom16HTMLFrameElementE)
> >>> referenced by ../../dom/html/Unified_cpp_dom_html1.o:(__ZTVN7mozilla3dom17HTMLIFrameElementE)
> lld-link: error: undefined symbol: __ZThn80_N25nsGenericHTMLFrameElement14GetFrameLoaderEv
> >>> referenced by ../../dom/html/Unified_cpp_dom_html1.o:(__ZTVN7mozilla3dom16HTMLFrameElementE)
> >>> referenced by ../../dom/html/Unified_cpp_dom_html1.o:(__ZTVN7mozilla3dom17HTMLIFrameElementE)
> lld-link: error: undefined symbol: __ZThn88_N22nsObjectLoadingContent14GetFrameLoaderEv
> >>> referenced by ../../dom/html/Unified_cpp_dom_html2.o:(__ZTVN7mozilla3dom17HTMLObjectElementE)

This is might be a clang bug?  I'm not sure if this is a patch we want to take; but it would unblock the mingw x86 build.

Comment 3

[Tom Ritter [:tjr]]

:smaug, assuming I fix up the commit message, what do you think of this patch?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

How super weird. Why GetFrameLoader needs special handling but InternalSetFrameLoader doesn't.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Why HTMLIFrameElement doesn't need the same stuff, even though the error seems to hint it would need?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9009652 [details]
Bug 1491846 GetFrameLoader inside child objects vtbls could not be resolved by linker. It looks like a clang bug, but requires closer look. I worked around it by having explicit forwards. r=Alex_Gaynor

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d61cb1fb3d2
GetFrameLoader inside child objects vtbls could not be resolved by linker. It looks like a clang bug, but requires closer look. I worked around it by having explicit forwards. r=smaug

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1d61cb1fb3d2

Comment 9

[Tom Ritter [:tjr]]

Comment on attachment 9009652 [details]
Bug 1491846 GetFrameLoader inside child objects vtbls could not be resolved by linker. It looks like a clang bug, but requires closer look. I worked around it by having explicit forwards. r=Alex_Gaynor

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix the mingw-clang build for esr60

User impact if declined: Tor will have to carry this patch themselves, and we won't be able to run mingw-clang in automation.

Fix Landed on Version: 64.0a1 / 20180919123806

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): We're only providing forwarding method stubs.

String or UUID changes made by this patch:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9009652 [details]
Bug 1491846 GetFrameLoader inside child objects vtbls could not be resolved by linker. It looks like a clang bug, but requires closer look. I worked around it by having explicit forwards. r=Alex_Gaynor

Let's uplift; support for better build automation for esr60 + downstream builds.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/27f9d9a5e91e