1492210 - nsCocoaUtils.mm compile error on macOS 10.13 with 10.14 SDK

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Miko Mynttinen]

Installed Xcode 10 today and encountered this error:

widget/cocoa/nsCocoaUtils.mm:1227:30: error: cannot initialize a variable of type 'GeckoAVAuthorizationStatus' with an rvalue of type 'AVAuthorizationStatus'
GeckoAVAuthorizationStatus authStatus =

I am guessing that the problem insufficients ifdefs, or that they do not like the combination of macOS 10.13 with 10.14 SDK. Fixed the problem locally with static_cast.

Comment 1

[Haik Aftandilian [:haik]]

Looking into this.

Until it's fixed, avoid downloading the new Xcode, or if you have access to an older SDK, you can use that with the following MOZCONFIG setting with the path to the older SDK within the Xcode bundle. I'm using the 10.11 SDK that comes with Xcode 7.3.1 to match what we use on try and for shipping builds.

  ac_add_options --with-macos-sdk=/path/to/the/SDK/MacOSX10.11.sdk

Comment 2

[Haik Aftandilian [:haik]]

Miko, with the new Xcode Version 10.0 (10A255), my opt build compiles without error. (My debug build is still running). Can you confirm the build of Xcode you have and also include the output of the "xcode-select -p" command?

Comment 3

[Miko Mynttinen]

This compile error occurred with local ASAN build, using mozconfig[1] that contains:
ac_add_options --with-macos-sdk=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk

Without this setting, the system SDK is used and build succeeds. The actual compile error still seems valid, since the code tries to assign enum of type AVAuthorizationStatus to GeckoAVAuthorizationStatus without casting. I have attached a patch to fix this.


[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Firefox_and_Address_Sanitizer#Building_Firefox

Comment 4

[Miko Mynttinen]

Attachment: Bug 1492210 - Cast AVAuthorizationStatus to GeckoAVAuthorizationStatus

Comment 5

[Haik Aftandilian [:haik]]

Comment on attachment 9010104 [details]
Bug 1492210 - Cast AVAuthorizationStatus to GeckoAVAuthorizationStatus

Haik Aftandilian [:haik] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07b4e13976f1
Cast AVAuthorizationStatus to GeckoAVAuthorizationStatus r=haik

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/07b4e13976f1