Closed Bug 1487204 Opened Last year Closed Last year

[macOS 10.14] Add platform support for calling authorizationStatusForMediaType and requestAccessForMediaType from JS

Categories

(Core :: Widget: Cocoa, enhancement, P1)

63 Branch
Unspecified
macOS
enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 + wontfix
firefox64 --- fixed

People

(Reporter: haik, Assigned: haik)

References

Details

Attachments

(1 file)

This bug is filed to cover adding support for authorizationStatusForMediaType and requestAccessForMediaType when we are running on macOS 10.14. On Mojave, access to the camera/mic from an application prompts the user to allow or deny access. 10.14 includes API's to query the current permission status and to request the permission.

I'm splitting the platform work out from bug 1479051 to this bug. See bug 1479051 for additional details.
Assignee: nobody → haftandilian
Priority: -- → P1
Add a new interface nsIOSPermissionRequest for querying the
staus of access permissions for audio/video media capture and
requesting access to audio/video capture devices. Provides an
implementation for macOS 10.14 and a default implementation
(nsOSPermissionRequestBase) for earlier macOS versions and other
platforms. The default implementation always returns status
indicating access is allowed.
Blocks: 1479051
Comment on attachment 9005012 [details]
Bug 1487204 - Add platform support for calling authorizationStatusForMediaType and requestAccessForMediaType from JS r?spohl

Stephen A Pohl [:spohl] has approved the revision.
Attachment #9005012 - Flags: review+
Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc550315583a
Add platform support for calling authorizationStatusForMediaType and requestAccessForMediaType from JS r=spohl
https://hg.mozilla.org/mozilla-central/rev/cc550315583a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Is this something we should consider for Beta uplift?
Flags: needinfo?(haftandilian)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Is this something we should consider for Beta uplift?

Once bug 1479051 is landed, we should consider uplifting the two to be ready for the release of macOS 10.14. Bug 1470833 is another 10.14 bug we will likely want to uplift, but it isn't in Nightly yet.
Flags: needinfo?(haftandilian)
(In reply to Haik Aftandilian [:haik] from comment #6)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> > Is this something we should consider for Beta uplift?
> 
> Once bug 1479051 is landed, we should consider uplifting the two to be ready
> for the release of macOS 10.14. Bug 1470833 is another 10.14 bug we will
> likely want to uplift, but it isn't in Nightly yet.

Tracking for 63 as 10.14 is likely to be released end of September.
Depends on: 1492210
Depends on: 1494851
Is this something we want to still consider for Beta uplift with a week left before the RC?
Flags: needinfo?(haftandilian)
QA Contact: mstange
QA Contact: mstange
(In reply to (PTO 8-Oct) Ryan VanderMeulen [:RyanVM] from comment #8)
> Is this something we want to still consider for Beta uplift with a week left
> before the RC?

No. This bug lays the groundwork for bug 1479051 which I hope to land this week and wouldn't want to uplift to Beta so late in the cycle.
Flags: needinfo?(haftandilian)
marking as wontfix for 63 as per comment #9
I've received some uplift requests for bug 1479051 and have filed the request for Beta on 1479051. I will file the uplift request for this bug this morning.
Comment on attachment 9005012 [details]
Bug 1487204 - Add platform support for calling authorizationStatusForMediaType and requestAccessForMediaType from JS r?spohl

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A, changes in macOS Mojave

User impact if declined: This is the platform support for bug 1479051 with impact "User may get into a situation where they have allowed cam/mic permission in Firefox for a site, but Firefox does not have access to the cam/mic and as a result those devices do not work. From the site's perspective, the cam/mic appear to work, but the received camera stream is just black pixels."

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): Changes are partially covered by automated tests for WebRTC. The changes are not very complex, only affect Mac builds, and some of the code is only used on Mojave.

String changes made/needed: None
Attachment #9005012 - Flags: approval-mozilla-beta?
Comment on attachment 9005012 [details]
Bug 1487204 - Add platform support for calling authorizationStatusForMediaType and requestAccessForMediaType from JS r?spohl

Not taking as we are not taking 1479051, thanks.
Attachment #9005012 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
See Also: → 1506283
You need to log in before you can comment on or make changes to this bug.