1492378 - Add support for ARC architecture

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement, P2)

Description

[alexey.brodkin]

Attachment: 0004-Add-ARC-support.patch

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180904093908

Steps to reproduce:

Tried to build NSPR for ARC architecture


Actual results:

----------------------------------------->8-------------------------------------------
| In file included from ../../../dist/include/nspr/prtypes.h:26,
|                  from ../../../dist/include/nspr/pratom.h:14,
|                  from ../../../dist/include/nspr/nspr.h:9,
|                  from ../../../../nspr-4.19/nspr/pr/include/private/primpl.h:31,
|                  from ../../../../nspr-4.19/nspr/pr/src/io/prfdcach.c:6:
| ../../../dist/include/nspr/prcpucfg.h:1162:2: error: #error "Unknown CPU architecture"
|  #error "Unknown CPU architecture"
|   ^~~~~
----------------------------------------->8-------------------------------------------


Expected results:

NSPR should be built for ARC.
Attached is a patch that add support of ARC architecture in NSPR

Comment 1

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9010158 [details] [diff] [review]
0004-Add-ARC-support.patch

Review of attachment 9010158 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. Is it really all that's needed?

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9010158 [details] [diff] [review]
0004-Add-ARC-support.patch

Mike, interested in taking this for NSPR?

Comment 3

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nspr/rev/cc73b6c7dab2e8053533e1f2c0c23dc721e10b76