1492404 - Partial downloads are not removed when "Clear on exit" is used

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Environment: 
Devices:
- Sony Z5 (Android 7.1.0)
- Samsung S7 (Android 8.0)
Build: Release 62, Nightly 64

Steps to reproduce:
1. Launch Fennec;
2. Go to Settings -> Privacy -> Clear private data on exit;
3. Check "Downloads" and tap Set;
4. Start a download (e.g. from https://www.thinkbroadband.com/download);
5. Tap Options and select "Quit" from the menu;
6. Choose to cancel all downloads when asked so;
7. Relaunch Fennec;
8. Go to Settings -> Tools -> Downloads;
9. With a Files Manager app check the Download folder;

Expected result:
The app quits cleanly and the entire list of downloads is cleared both from history and from the Download folder.

Actual result:
Partial downloads are still kept in history and in the Download folder.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

While investigating this I saw that going to 
> Settings -> Clear private data
with Downloads checked
also does not clear the partial downloads (paused or ongoing).

Comment 2

[Jan Henning [:JanH]]

Both ways ultimately end up with the Sanitizer (Sanitizer.jsm), so that's not totally unexpected.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r?sdaswani

Whenever Fennec asks to sanitize downloads all downloads will be deleted,
irrespective of their current status (will include in progress downloads).

Only when browsingData.removeDownloads WebExtension asks to sanitize downloads
we will check to make sure a specific download conforms and can be deleted.

Comment 4

[Jan Henning [:JanH]]

Comment on attachment 9012184 [details]
Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r?sdaswani

Jan Henning [:JanH] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc16bc807209
Remove all downloads when Fennec asked to sanitize them; r=JanH

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc16bc807209

Comment 7

[Stefan Deiac]

Verified as fixed on the latest build of Nightly 64.0a1 (2018-10-07) using both scenarios with Nokia 6 (Android 7.1.1), Samsung Galaxy S7 Edge (Android 8.0.0), Sony Xperia Z5 Premium (Android 6.0.1) and OnePlus 5T (Android 8.1.0).

Comment 8

[Pascal Chevrel:pascalc]

Is that something we can consider for beta uplift?

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9012184 [details]
Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r?sdaswani

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Privacy issue: Partial downloads are kept after the app is closed even if the user chose for all downloads to be cleared from history.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: --

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small change, verified by QA.

String changes made/needed: --

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9012184 [details]
Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r?sdaswani

Bug fix for fennec download history management, baked a week on nightly, uplift approved for 63 beta 13, thanks.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ebaffd428e7

Comment 12

[Sorina Florean [:sflorean]]

Tested with Motorola Nexus 6(Android 7.1.1), Nexus 9(Android 6.0.1), Sony Xperia Z5 (Android 7.0) and this issue is still reproducible on 63 beta 13. I've filed bug 1497502. 

However, on Sony Xperia Z5 Premium(Android 6.0.1) the issue is fixed on the latest Beta build. Keeping the qe-verify flag to check when the issue is fixed.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

As we are close from the 63 release, wontfix for 62.

Comment 15

[Bogdan Surd, QA [:bsurd, NI]]

Verified in the latest Beta (63.0b15) following the steps provided in Comment 0. Nothing is kept in the downloads folder after quitting FF.