1492516 - Grid badge disappears when updating node style

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Regression from 1479505

STRs:
- open https://labs.jensimmons.com/2017/01-003.html
- open inspector, and find the first <ul c;ass=".grid-container">
  (should have a "grid" badge at the end of the line)
- select the node in the markup-view
- in rule view, update `display` to `block`
  ("grid" badge disappears)
- in rule view, restore `display` to `grid`

ER: `grid` badge should reappear
AR: `grid` badge is missing

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: fix1492516.patch

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8680143b91825bf758bd53e024e6768398428fa0

Comment 2

[Julian Descottes [:jdescottes]]

Thanks for the review! Try is green, landing.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adea59821e6b
Delete badge properties when removing badge element from the DOM;r=gl

Comment 4

[Julian Descottes [:jdescottes]]

Reminder to ask for uplift after this reached m-c

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/adea59821e6b

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: fix1492516-beta.patch

Would be nice to get this fix for a 63 regression in beta, as it impacts features related to CSS grid and WebComponents (rolling out in 63).

Approval Request Comment
[Feature/Bug causing the regression]:1479505
[User impact if declined]:badges in the inspector (indicating if an element has events, is using grid, has custom elements etc...) may disappear after the elements are updated
[Is this code covered by automated tests?]:yes, added in this patch
[Has the fix been verified in Nightly?]:not yet
[Needs manual test from QE? If yes, steps to reproduce]: yes, steps in summary
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:simple javascript fix, automated tests added
[String changes made/needed]:none

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9010527 [details] [diff] [review]
fix1492516-beta.patch

Fix for a devtools regression, uplift approved for 63 beta 8. I'd like QE to verify the uplift, thanks.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40f14023347f

Comment 9

[Cristian Fogel [:cfogel]]

Managed to reproduce with 63.0a1 (2018-08-18).
Verified with 63.0b8, 64.0a1 (2018-09-21, on win10x64, macOS 10.13.6, Ubuntu16.04 can confirm that the issue is no longer reproducible.