1479505 - Markup view badges should not be created until they need to be displayed

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

In element-editor.js we create upfront the markup for all badges (event, display, custom) regardless of the characteristics of the node. We also attach click events on both the display and custom badges.

We could wait until the badges actually need to be displayed to create the markup. This seems to have a performance impact on expanding big trees:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=ff63a60360b2&newProject=try&newRevision=9d14dee6f23dd3ce4198a8164e79574a5e9e5fdb&originalSignature=2fa549258445b035f7463afad97852e46b399a6d&newSignature=2fa549258445b035f7463afad97852e46b399a6d&showOnlyConfident=1&framework=1

Link to a WIP patch: https://hg.mozilla.org/try/rev/593c9ea1480885881108ac1b87a1c76c9ea25306 (this patch does not guarantee the position of the badges relative to one another and fails some mochitests relying on the technical implementation of the badges).

Comment 1

[Julian Descottes [:jdescottes]]

try with attempt to fix tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c1ca48454921ac703f51a34eaf34e4ea774d6bb

Also pushed another cset to talos, this time only skipping the event listeners. Curious to see what is the share of the markup creation vs attaching events: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd4dbaf04e90064d556eea559ebd63e7a2a77179

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479505 - Create markupview badges only when first accessed;r=ochameau

Comment 3

[Phabricator Automation]

Comment on attachment 8996206 [details]
Bug 1479505 - Create markupview badges only when first accessed;r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.

https://phabricator.services.mozilla.com/D2548

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3164883c3cba
Create markupview badges only when first accessed;r=ochameau

Comment 5

[Julian Descottes [:jdescottes]]

Hmmm I had updated the commit message to better reflect the final implementation, but it looks like phabricator doesn't pick this up automatically.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3164883c3cba