1492525 - Deformed and glichy terminal on stripe.com (at 280+% zoom)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Spin-off from bug 1492016.

(Jan Andre Ikenmeyer [:darkspirit] from bug 1492016 comment 5)
> Created attachment 9010327 [details]
> 2018-09-19_18-45-13.mp4
> 
> We should never miss the opportunity to find another bug.
> 
> Debian Testing, KDE, Xorg, GTX 1060 (driver 390.77)
> Try build from bug 1492389 comment 1.
> Only broken at 280%.

(Emilio Cobos Álvarez (:emilio) from bug 1492016 comment 7)
> Comment 5 is reproducible on linux / intel, so it's probably a transform-related bug instead.

Comment 1

[Darkspirit]

last good = the purple terminal is not deformed

mozregression --good 2018-08-15 --bad 2018-09-19 --pref gfx.webrender.all:true -a https://stripe.com/terminal
> 9:04.64 INFO: Last good revision: e414fcdabb7209d3ac6a0052f4c0c8c8c89ab35d
> 9:04.64 INFO: First bad revision: 5bfe272aa1a2e80b562e245b48346e9c5aa4acee
> 9:04.64 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e414fcdabb7209d3ac6a0052f4c0c8c8c89ab35d&tochange=5bfe272aa1a2e80b562e245b48346e9c5aa4acee

> 5bfe272aa1a2	Jeff Muizelaar — Bug 1490242. Adjust reftests for 3d transfrom changes
> 8c80d5351916	Jeff Muizelaar — Bug 1490242. Update webrender to 04d63e7d73b9661d9eb934a0933c8f9751a9a3db

Comment 2

[Darkspirit]

= Regressed by https://github.com/servo/webrender/pull/3030

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Thoughts Glenn?

Comment 4

[Darkspirit]

https://github.com/servo/webrender/issues/3087#issuecomment-423595274
> With latest Nightly it's no longer deformed like in the screencast for me, so the mentioned regression range might be obsolete. But there is still some flicker on the left side of the purple terminal if you zoom in.

Comment 5

[Glenn Watson [:gw]]

It sounds like emilio has a fix for this in progress with https://github.com/servo/webrender/pull/3187.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yup, taking. I hope to figure out the text subpixel issues quick :)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

This was fixed by that PR.

Comment 8

[Darkspirit]

Attachment: 2018-10-24_17-59-34.mp4

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
> text subpixel issues

mozregression --launch 2018-10-24 --pref gfx.webrender.all:true general.autoScroll:true -a https://stripe.com/terminal

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> Created attachment 9019748 [details]
> 2018-10-24_17-59-34.mp4
> 
> (In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
> > text subpixel issues
> 
> mozregression --launch 2018-10-24 --pref gfx.webrender.all:true
> general.autoScroll:true -a https://stripe.com/terminal

Oh, I meant the ones that were causing failures in my WR PR.

I can't seem to reproduce that, but right now I'm on my laptop which has a HiDPI screen so probably I can't even.

If that looks worse than non-WR or other browsers, mind filing another bug for that? Probably lsalzman is the best person to look at that but I could also take a look.