1492640 - TB60 ugly notification image Windows 10

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Marco A.G.Pinto [:marcoagpinto]]

Attachment: TB60_ugly_notification_image_win10_20180920.png

Hello!

A couple or so of years ago, Wayne told me to check for a bug report by changing a setting in TB.

So, it shows a Windows notification and I don't know how to turn it off.

The problem in it is that the image that appears there is very ugly (all pixelized).

Could someone improve the image?

Thank you!

Comment 1

[Wayne Mery (:wsmwk)]

I think I have seen this. perhaps others have

Comment 2

[Richard Marti (:Paenglab)]

Marco, you have set mail.biff.show_alert to false and mail.biff.show_balloon to true, then the notification shows in the action center instead the TB notification. I can play with adding bigger TB icons to not show the new mail icon and instead the TB icon.

Comment 3

[Marco A.G.Pinto [:marcoagpinto]]

Yes, it was Wayne who told me to change a setting years ago to test a bug report, then I didn't remember how to turn it back to the default setting.

Comment 4

[Marco A.G.Pinto [:marcoagpinto]]

How do I change it? I can't remember.

Comment 5

[Richard Marti (:Paenglab)]

In Options go to Advanced/General click on "Config Editor...", accept the warning when it shows (depending of config) and enter the prefs names I wrote above in the search field. With double click the prefs toggles.

Comment 6

[Marco A.G.Pinto [:marcoagpinto]]

Thanks, it has worked :-)

Comment 7

[Richard Marti (:Paenglab)]

Rob, I have a newmail.ico for Daily that I plan to have in mail/branding/nightly/ and one for Thunderbird in mail/branding/thunderbird/ which will be loaded here: https://searchfox.org/comm-central/source/mail/app/splash.rc#20.

How can we switch the icon depending of the MOZ_OFFICIAL_BRANDING in splash.rc? Could we do this also with a path variable in splash.rc?

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1492640-biff-icons.patch

This is my patch without the switch logic. It uses always the nightly ICO. But with this you can play.

Comment 9

[Rob Lemley [:rjl]]

Attachment: newmail_ico_rjl.patch

Something like this ought to do it.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1492640-biff-icons.patch

Thank you, Rob. This seems to work as the nightly icon is loaded in my build.

This patch changes the biff icon in the task bar to one that fits better with the Windows 10 taskbar icons (see taskbar.png).

Additionally, when mail.biff.show_alert is set to false and mail.biff.show_balloon to true, where is the program icon shown instead of the old biff icon (comparison.png).

I tried with a 32px icon for the biff icon in the task bar which looks better under Windows 10 but under Windows 7 (it doesn't use the 16px icon but the 32px) the icon isn't scaled so well and some black border is missing. We could move to the 32px icon when Windows 7 is no more supported.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: taskbar.png

Alessandro, what do you think to this icon?

Comment 12

[Richard Marti (:Paenglab)]

Attachment: comparison.png

And to the new icons in this comparison? The official TB will use it's original icon.

Comment 13

[Alessandro Castellani [:aleca]]

Comment on attachment 9063883 [details]
comparison.png

Definitely better than the old one.
So, TB 60 will show its icon, beta will show its icon, and so on, right?
Is this notification appearing only for new messages, or the Windows notification system handles also calendar reminders, tasks, chat, etc?

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9063881 [details] [diff] [review]
1492640-biff-icons.patch

Looks OK, I applied the patch and checked the icons, too. There are two layers/icons in the files, one for the TB logo and one for the tray.

Comment 15

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #13)

Comment on attachment 9063883 [details]
comparison.png

Definitely better than the old one.
So, TB 60 will show its icon, beta will show its icon, and so on, right?

Yes, TB 60 and beta use the same program icon and there will be no difference. I'm not sure if we should apply the patch to TB 60 too in this late phase.

Is this notification appearing only for new messages, or the Windows
notification system handles also calendar reminders, tasks, chat, etc?

I don't use this setting as default and can't say if all this notifications are used but the biff icon should be only used for new mail notifications. When other such notifications are used, Windows 10 should use the program icon.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a26392321720
Change new mail icon and add bigger icons for the action center. r=jorgk