1492777 - Failing CFR mochitest - browser/components/newtab/test/browser/browser_asrouter_cfr.js

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Andrei Oprea [:andreio]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1489962#c7

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/89f12a8030bcb8e53018b829c2175b5261bdb7c4
(nobug): Skip failing mochitest browser_asrouter_cfr.js

This will by reverted in Bug 1492777

Comment 2

[Ed Lee :Mardak]

Bug 1485305 landed on inbound when activity stream export bug 1489962 landed on autoland. Seems relevant for the test failure:

[task 2018-09-19T23:17:12.767Z] 23:17:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_cfr.js | Uncaught exception - at chrome://browser/content/browser.js:1047 - Error: Must load with a triggering Principal

Comment 3

[Ed Lee :Mardak]

I noted in phabricator that using test utils to load uri would have avoided the test failure:

-  browser.loadURI("http://example.com");
+  await BrowserTestUtils.loadURI(browser, "http://example.com/");

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4443

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ce908fb729e1c82c9df493c469712a9d05e55c80
Fix Bug 1492777 - Failing CFR mochitest browser_asrouter_cfr.js (#4443)

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/95f8e6265f24