Closed
Bug 1492856
Opened 6 years ago
Closed 6 years ago
Remove compatiblity code to guard against miss of RootActor.getRoot
Categories
(DevTools Graveyard :: WebIDE, enhancement)
DevTools Graveyard
WebIDE
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
There is some non trivial hack to support FF55-, related to bug 1352157.
I think it would be safer to remove it from WebIDE and instead make checkRuntimeVersion identify this miss and report the runtime as deprecated.
It should be easier then for about:debugging to report deprecated runtimes without having to do the same hack that WebIDE was doing.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: L5kkG9r7Rtv
Assignee | ||
Comment 2•6 years ago
|
||
Somewhat green try (I fixed the eslint errors):
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=201211264&revision=f7de81e678d2ae7e052e97da3938fb2b5563bdcc
Comment 3•6 years ago
|
||
Comment on attachment 9011725 [details]
Bug 1492856 - Remove compatiblity code to guard against miss of RootActor.getRoot
Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9011725 -
Flags: review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddf82df76415
Remove compatiblity code to guard against miss of RootActor.getRoot r=jdescottes
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•