Closed
Bug 1492884
Opened 7 years ago
Closed 7 years ago
Fix tabs API for WebExtensions after bug 1396684
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Tracking
(thunderbird63 fixed, thunderbird64 fixed)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
712 bytes,
patch
|
darktrojan
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Bug 1396684 added a new property to the `TabBase` object so Thunderbird needs to add an override for it.
| Assignee | ||
Comment 1•7 years ago
|
||
Attachment #9010669 -
Flags: review?(philipp)
Comment 2•7 years ago
|
||
Comment on attachment 9010669 [details] [diff] [review]
Proposed patch
Maybe Geoff can do this faster.
Attachment #9010669 -
Flags: review?(geoff)
Comment 3•7 years ago
|
||
Comment on attachment 9010669 [details] [diff] [review]
Proposed patch
Review of attachment 9010669 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #9010669 -
Flags: review?(philipp)
Attachment #9010669 -
Flags: review?(geoff)
Attachment #9010669 -
Flags: review+
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/997d19872dcf
Add 'attention' to tabs API for WebExtensions after bug 1396684. r=darktrojan
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 64.0
Updated•7 years ago
|
Attachment #9010669 -
Flags: approval-comm-beta+
Comment 5•7 years ago
|
||
Beta (TB 63):
https://hg.mozilla.org/releases/comm-beta/rev/4c53b45ab4e4349c2da8e2c4353b30e73ae82407
status-thunderbird63:
--- → fixed
status-thunderbird64:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•