Closed Bug 1492884 Opened 2 years ago Closed 2 years ago

Fix tabs API for WebExtensions after bug 1396684

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird63 fixed, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird63 --- fixed
thunderbird64 --- fixed

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Bug 1396684 added a new property to the `TabBase` object so Thunderbird needs to add an override for it.
Attached patch Proposed patchSplinter Review
Attachment #9010669 - Flags: review?(philipp)
Comment on attachment 9010669 [details] [diff] [review]
Proposed patch

Maybe Geoff can do this faster.
Attachment #9010669 - Flags: review?(geoff)
Comment on attachment 9010669 [details] [diff] [review]
Proposed patch

Review of attachment 9010669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #9010669 - Flags: review?(philipp)
Attachment #9010669 - Flags: review?(geoff)
Attachment #9010669 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/997d19872dcf
Add 'attention' to tabs API for WebExtensions after bug 1396684. r=darktrojan
Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Attachment #9010669 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.