Closed Bug 1492893 Opened Last year Closed Last year

Cleanup: remove the toolbox data from the redux state

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
enhancement
Priority:
Not set

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(1 file)

Bug 1492893 - [Devtools Performance-new] Remove the unused toolbox object from the redux store
46 bytes, text/x-phabricator-request
gregtatum
: review+
Details | Review 
Initially we added the toolbox object to the redux state so that we can use it to open a link in a new tab.

However we don't need the object anymore since bug 1458591. Moreover the object is always available as a global variable `gToolbox` anyway in case we need it, so we don't need to put it in the redux store.
Comment on attachment 9010866 [details]
Bug 1492893 - [Devtools Performance-new] Remove the unused toolbox object from the redux store

Greg Tatum [:gregtatum] has approved the revision.
Attachment #9010866 - Flags: review+
Pushed by jwajsberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/267392b7c692
[Devtools Performance-new] Remove the unused toolbox object from the redux store r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/267392b7c692
Status: NEW → RESOLVED
Closed: Last year
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.