1492917 - Use the --enable-hardening configure flag for Mac builds

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Haik Aftandilian [:haik]]

This bug is to cover to turning on the --enable-hardening flag introduced by bug 620058 on Mac builds. Turning this on is going to include the changes to set the flag and also performance testing to determine performance impacts.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

First look at performance difference seems ok: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f921a8bf821c2b8c9b16636d7a5d11285c76059a

The current patch for Bug 1503589 will flip this for all "gcc and clang like" compilers. So if that lands, it will cover this as well.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&newProject=try&newRevision=f921a8bf821c&framework=1&showOnlyComparable=1&selectedTimeRange=172800

2 tests with 2-3% regression, everything else less, so that should be within the expected range.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

I'm going to close this based on bug 1503589 and bug 1359905 landing (assuming the latter doesn't get backed out).