47 bytes, text/x-phabricator-request
|Details | Review|
Created as a clone of https://bugzilla.mozilla.org/show_bug.cgi?id=620058 which contains more context.
For context, right now |js/| has |-fno-stack-protector| https://dxr.mozilla.org/mozilla-central/source/js/src/old-configure.in#562 This dates back to https://hg.mozilla.org/mozilla-central/rev/663a3afb238e. A first task for this issue would be to validate if there are still issues if that commit is reverted.
This was disabled in https://hg.mozilla.org/mozilla-central/rev/663a3afb238e I'm going to do a full try push with it reverted, and see what our status is.
Looking at the current configure code, it does seem that this is currently only disabled on Mac, i.e. that we are already using stack protector strong on all other targets: https://searchfox.org/mozilla-central/rev/b096dcf0ea226af628fe03f7e7acb56a25853533/js/src/old-configure.in#575
Enable hardening on macOS, enable fstack-protector-strong on js/.
Attachment #9024044 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cceb6f9235a1 Enable fstack-protector-strong on js/. r=glandium
You need to log in before you can comment on or make changes to this bug.