Closed Bug 1359905 Opened 8 years ago Closed 6 years ago

Enable fstack-protector-strong on js/

Categories

(Core :: Security, enhancement, P3)

Product:
Core
Component:
Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: tjr, Assigned: gcp)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [sg:want][adv-main65-])

Attachments

(1 file, 1 obsolete file)

Bug 1359905 - Enable fstack-protector-strong on js/.
47 bytes, text/x-phabricator-request
Details | Review
Created as a clone of https://bugzilla.mozilla.org/show_bug.cgi?id=620058 which contains more context.
Depends on: 1359908
Depends on: 1359912
Depends on: 1359914
Depends on: 1359915
Depends on: 1359918
Depends on: 1359920
Depends on: 1359926
Depends on: 1359928
For context, right now |js/| has |-fno-stack-protector| https://dxr.mozilla.org/mozilla-central/source/js/src/old-configure.in#562 This dates back to https://hg.mozilla.org/mozilla-central/rev/663a3afb238e. A first task for this issue would be to validate if there are still issues if that commit is reverted.
Depends on: 1360299
Depends on: 1360300
Depends on: 1360301
No longer depends on: 1359918
No longer depends on: 1360301
No longer depends on: 1360300
No longer depends on: 1360299
No longer depends on: 1359912
No longer depends on: 1359908, 1359915, 1359920, 1359926, 1359928, 671426, 1359914
Priority: -- → P3
Assignee: nobody → gpascutto
This was disabled in https://hg.mozilla.org/mozilla-central/rev/663a3afb238e I'm going to do a full try push with it reverted, and see what our status is.
Looking at the current configure code, it does seem that this is currently only disabled on Mac, i.e. that we are already using stack protector strong on all other targets: https://searchfox.org/mozilla-central/rev/b096dcf0ea226af628fe03f7e7acb56a25853533/js/src/old-configure.in#575
Enable hardening on macOS, enable fstack-protector-strong on js/.
Attachment #9024044 - Attachment is obsolete: true
Pushed by gpascutto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cceb6f9235a1 Enable fstack-protector-strong on js/. r=glandium
https://hg.mozilla.org/mozilla-central/rev/cceb6f9235a1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Whiteboard: [sg:want] → [sg:want][adv-main65-]

Bug 1533133 suggests that due to the js_flags logic this wasn't enough to enable it.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: