1492950 - Get rid of tabbrowser.getBrowserForContentWindow and friends

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1492482, I'm getting rid of contentDocumentAsCPOW and contentWindowAsCPOW. getBrowserForContentWindow, and anything that relies on _getTabForContentWindow, relies on contentWindowAsCPOW, and needs to be dropped.

This sweater is coming undone.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9eb2e2906d485494023873a7737c1170d2323e3

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Move ZoomManager reset for crashed tabs into ContentCrashHandlers.jsm. r?felipe

Depends on D6706

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r?MattN

Depends on D6709

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r?florian

Depends on D6710

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r?MattN

Depends on D6711

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r?jaws

Depends on D6712

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get browser.js off of getBrowserForContentWindow. r?Gijs

Depends on D6713

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r?NeilDeakin

Depends on D6714

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get tabbrowser.js and browser.js off of _getTabForContentWindow. r?NeilDeakin

Depends on D6715

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r?NeilDeakin

Depends on D6716

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9011611 [details]
Bug 1492950 - Move ZoomManager reset for crashed tabs into ContentCrashHandlers.jsm. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 12

[:Gijs (he/him)]

Comment on attachment 9011618 [details]
Bug 1492950 - Get browser.js off of getBrowserForContentWindow. r?Gijs

:Gijs (he/him) has approved the revision.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9011617 [details]
Bug 1492950 - Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r?jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 14

[Neil Deakin]

Comment on attachment 9011619 [details]
Bug 1492950 - Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r?NeilDeakin

Neil Deakin has approved the revision.

Comment 15

[Neil Deakin]

Comment on attachment 9011625 [details]
Bug 1492950 - Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r?NeilDeakin

Neil Deakin has approved the revision.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1492950 - Get rid of tabbrowser.getBrowserIndexForDocument. r?mikedeboer

Comment 17

[Mike de Boer [:mikedeboer]]

Comment on attachment 9011907 [details]
Bug 1492950 - Get rid of tabbrowser.getBrowserIndexForDocument. r?mikedeboer

Mike de Boer [:mikedeboer] has approved the revision.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Try looking solid: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=201441739&revision=4d6bd70a8d62225867739d8a52d40b1c34c20622

Comment 19

[Neil Deakin]

Comment on attachment 9011622 [details]
Bug 1492950 - Get tabbrowser.js and browser.js off of _getTabForContentWindow. r?NeilDeakin

Neil Deakin has approved the revision.

Comment 20

[Florian Quèze [:florian]]

Comment on attachment 9011614 [details]
Bug 1492950 - Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r?florian

Florian Quèze [:florian] has approved the revision.

Comment 21

[:Gijs (he/him)]

Comment on attachment 9011613 [details]
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r?MattN

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.

Comment 22

[Matthew N. [:MattN]]

Comment on attachment 9011613 [details]
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 23

[Matthew N. [:MattN]]

Comment on attachment 9011616 [details]
Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/193cb0e60150
Get rid of tabbrowser.getBrowserIndexForDocument. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/00a4cf01fa97
Move ZoomManager reset for crashed tabs into ContentCrashHandlers.jsm. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/bb9fc6495914
Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN
https://hg.mozilla.org/integration/autoland/rev/9bb5657e614c
Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r=florian
https://hg.mozilla.org/integration/autoland/rev/bd55b04144dc
Get login prompter off of getBrowserForContentWindow. r=MattN
https://hg.mozilla.org/integration/autoland/rev/680d1feab4fe
Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r=jaws
https://hg.mozilla.org/integration/autoland/rev/492867ee197f
Get browser.js off of getBrowserForContentWindow. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a1b2eb69cd3c
Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/1940595cb776
Get tabbrowser.js and browser.js off of _getTabForContentWindow. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/48be1c7d47ef
Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r=NeilDeakin

Comment 25

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/193cb0e60150
https://hg.mozilla.org/mozilla-central/rev/00a4cf01fa97
https://hg.mozilla.org/mozilla-central/rev/bb9fc6495914
https://hg.mozilla.org/mozilla-central/rev/9bb5657e614c
https://hg.mozilla.org/mozilla-central/rev/bd55b04144dc
https://hg.mozilla.org/mozilla-central/rev/680d1feab4fe
https://hg.mozilla.org/mozilla-central/rev/492867ee197f
https://hg.mozilla.org/mozilla-central/rev/a1b2eb69cd3c
https://hg.mozilla.org/mozilla-central/rev/1940595cb776
https://hg.mozilla.org/mozilla-central/rev/48be1c7d47ef