Get rid of tabbrowser.getBrowserForContentWindow and friends

RESOLVED FIXED in Firefox 64

Status

()

P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(10 attachments)

46 bytes, text/x-phabricator-request
Felipe
: review+
Details | Review
46 bytes, text/x-phabricator-request
Gijs
: review+
MattN
: review+
Details | Review
46 bytes, text/x-phabricator-request
florian
: review+
Details | Review
46 bytes, text/x-phabricator-request
MattN
: review+
Details | Review
46 bytes, text/x-phabricator-request
jaws
: review+
Details | Review
46 bytes, text/x-phabricator-request
Gijs
: review+
Details | Review
46 bytes, text/x-phabricator-request
enndeakin
: review+
Details | Review
46 bytes, text/x-phabricator-request
enndeakin
: review+
Details | Review
46 bytes, text/x-phabricator-request
enndeakin
: review+
Details | Review
46 bytes, text/x-phabricator-request
mikedeboer
: review+
Details | Review
(Assignee)

Description

6 months ago
In bug 1492482, I'm getting rid of contentDocumentAsCPOW and contentWindowAsCPOW. getBrowserForContentWindow, and anything that relies on _getTabForContentWindow, relies on contentWindowAsCPOW, and needs to be dropped.

This sweater is coming undone.
(Assignee)

Updated

6 months ago
Assignee: nobody → mconley
Priority: -- → P1
Comment on attachment 9011611 [details]
Bug 1492950 - Move ZoomManager reset for crashed tabs into ContentCrashHandlers.jsm. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.
Attachment #9011611 - Flags: review+

Comment 12

6 months ago
Comment on attachment 9011618 [details]
Bug 1492950 - Get browser.js off of getBrowserForContentWindow. r?Gijs

:Gijs (he/him) has approved the revision.
Attachment #9011618 - Flags: review+
Comment on attachment 9011617 [details]
Bug 1492950 - Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r?jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9011617 - Flags: review+
Comment on attachment 9011619 [details]
Bug 1492950 - Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r?NeilDeakin

Neil Deakin has approved the revision.
Attachment #9011619 - Flags: review+
Comment on attachment 9011625 [details]
Bug 1492950 - Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r?NeilDeakin

Neil Deakin has approved the revision.
Attachment #9011625 - Flags: review+
Comment on attachment 9011907 [details]
Bug 1492950 - Get rid of tabbrowser.getBrowserIndexForDocument. r?mikedeboer

Mike de Boer [:mikedeboer] has approved the revision.
Attachment #9011907 - Flags: review+
Comment on attachment 9011622 [details]
Bug 1492950 - Get tabbrowser.js and browser.js off of _getTabForContentWindow. r?NeilDeakin

Neil Deakin has approved the revision.
Attachment #9011622 - Flags: review+
Comment on attachment 9011614 [details]
Bug 1492950 - Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r?florian

Florian Quèze [:florian] has approved the revision.
Attachment #9011614 - Flags: review+

Comment 21

6 months ago
Comment on attachment 9011613 [details]
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r?MattN

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.
Attachment #9011613 - Flags: review+
Comment on attachment 9011613 [details]
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9011613 - Flags: review+
Comment on attachment 9011616 [details]
Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9011616 - Flags: review+

Comment 24

6 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/193cb0e60150
Get rid of tabbrowser.getBrowserIndexForDocument. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/00a4cf01fa97
Move ZoomManager reset for crashed tabs into ContentCrashHandlers.jsm. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/bb9fc6495914
Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN
https://hg.mozilla.org/integration/autoland/rev/9bb5657e614c
Get browser-fullZoom.js and ZoomUI.jsm off of getBrowserForDocument. r=florian
https://hg.mozilla.org/integration/autoland/rev/bd55b04144dc
Get login prompter off of getBrowserForContentWindow. r=MattN
https://hg.mozilla.org/integration/autoland/rev/680d1feab4fe
Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r=jaws
https://hg.mozilla.org/integration/autoland/rev/492867ee197f
Get browser.js off of getBrowserForContentWindow. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a1b2eb69cd3c
Don't allow CPOW windows to be passed to SimpleTest.waitForFocus. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/1940595cb776
Get tabbrowser.js and browser.js off of _getTabForContentWindow. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/48be1c7d47ef
Get rid of getBrowserForDocument, getBrowserForContentWindow and _getTabForContentWindow. r=NeilDeakin
You need to log in before you can comment on or make changes to this bug.