1492482 - Stop sending CPOWs from RemoteWebProgress.jsm

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

We send CPOWs as a way of populating things like remote-browser.xml's contentDocumentAsCPOW and contentWindowAsCPOW.

Thanks to kmag, I've narrowed down the leak from bug 1472212 to the CPOWs that we're sending up. Instead of trying to work around it, I think enough is enough with the CPOWs - let's just try to get rid of them coming up from RemoteWebProgress.

Comment 2

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Making progress here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f3ef1acebec15d70dcedf9628e84b24d130e03f

Comment 3

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Get rid of tabbrowser.getBrowserIndexForDocument. r?mikedeboer

Comment 4

[Kris Maglione [:kmag]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)
> Making progress here:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=9f3ef1acebec15d70dcedf9628e84b24d130e03f

\o/

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 9011608 [details]
Bug 1492482 - Get rid of tabbrowser.getBrowserIndexForDocument. r?mikedeboer

Mike de Boer [:mikedeboer] has approved the revision.

Comment 6

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

My patches, somehow, get rid of a circular reference in Protocol actors for DevTools, which means that they don't throw here:

https://searchfox.org/mozilla-central/rev/ffe6eaf2f032e58ec3b0650a87df2c62ae4ca441/devtools/client/shared/redux/middleware/log.js#13

Historically, it was throwing, and we'd console.log the short thing, but now without the circular reference, we're logging the fully stringified objects which is causing the tests to time out.

In bug 1473513, it looks like :yulia is fixing this for similar reasons, so setting up a dependency. yulia tells me that those patches are likely to land soon.

Comment 7

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_keywordSearch_postData.js r?mkaply

Depends on D6718

Comment 8

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_tab_dragdrop2.js. r?Gijs

Depends on D6947

Comment 9

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_pageinfo_image_info.js r?florian

Depends on D6949

Comment 10

[:Gijs (he/him)]

Comment on attachment 9012274 [details]
Bug 1492482 - Remove CPOW usage from browser_tab_dragdrop2.js. r?Gijs

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.

Comment 11

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_Bug 1492482.js r?johannh

Depends on D6950

Comment 12

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_urlbarHashChangeProxyState.js r?Gijs

Depends on D6952

Comment 13

[:Gijs (he/him)]

Comment on attachment 9012279 [details]
Bug 1492482 - Remove CPOW usage from browser_urlbarHashChangeProxyState.js r?Gijs

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.

Comment 14

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_urlbarKeepStateAcrossTabSwitches.js. r?Gijs

Depends on D6953

Comment 15

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_usercontext.js. r?felipe

Depends on D6954

Comment 16

[:Gijs (he/him)]

Comment on attachment 9012281 [details]
Bug 1492482 - Remove CPOW usage from browser_urlbarKeepStateAcrossTabSwitches.js. r?Gijs

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.

Comment 17

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_aboutSearchReset.js. r?nhnt11

Depends on D6955

Comment 18

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove browser_abouthome_behavior.js test. r?mkaply

This test appears to have been disabled since 2014, and about:home has changed
a whole bunch since then. I also believe that searching from the new about:home
is being tested elsewhere.

Depends on D6956

Comment 19

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_1119088.js. r?mstange

Depends on D6957

Comment 20

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_onboarding_skip_tour.js. r?ursula

Depends on D6958

Comment 21

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_onboarding_tourset.js. r?ursula

Depends on D6959

Comment 22

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_dbg_event-listeners-01.js. r?jdescottes

Depends on D6960

Comment 23

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_dbg_event-listeners-02.js. r?jdescottes

Depends on D6961

Comment 24

[Johann Hofmann [:johannh]]

Comment on attachment 9012277 [details]
Bug 1492482 - Remove CPOW usage from browser_Bug 1492482.js r?johannh

Johann Hofmann [:johannh] has approved the revision.

Comment 25

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOWs from devtools/client/debugger/test/mochitest/head.js. r?jdescottes

Depends on D6963

Comment 26

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_aboutnewtab_process_selection.js. r?felipe

Depends on D6967

Comment 27

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_readerMode_with_anchor.js. r?Gijs

Depends on D6968

Comment 28

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_datetime_picker.js. r?felipe

Depends on D6969

Comment 29

[:Gijs (he/him)]

Comment on attachment 9012302 [details]
Bug 1492482 - Remove CPOW usage from browser_readerMode_with_anchor.js. r?Gijs

:Gijs (out Thu 27 - Sun 30 / 9;  he/him) has approved the revision.

Comment 30

[Ursula Sarracini (:ursula)]

Comment on attachment 9012287 [details]
Bug 1492482 - Remove CPOW usage from browser_onboarding_skip_tour.js. r?ursula

Ursula Sarracini (:ursula) has approved the revision.

Comment 31

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Remove CPOW usage from browser_saveImageURL.js. r?baku

This also "fixes" what appears to be some broken checks by switching
them to todo()'s. I filed bug 1492885 to investigate these busted
checks, and re-enable them.

Depends on D6970

Comment 32

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Stop using contentDocumentAsCPOW in browser_1119088.js. r?felipe

Depends on D6971

Comment 33

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1492482 - Stop sending CPOWs with WebProgressChild messages. r?felipe

Depends on D6972

Comment 34

[Ursula Sarracini (:ursula)]

Comment on attachment 9012289 [details]
Bug 1492482 - Remove CPOW usage from browser_onboarding_tourset.js. r?ursula

Ursula Sarracini (:ursula) has approved the revision.

Comment 35

[Markus Stange [:mstange]]

Comment on attachment 9012285 [details]
Bug 1492482 - Remove CPOW usage from browser_1119088.js. r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 36

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9012305 [details]
Bug 1492482 - Stop using contentDocumentAsCPOW in browser_1119088.js. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 37

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9012303 [details]
Bug 1492482 - Remove CPOW usage from browser_datetime_picker.js. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 38

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9012301 [details]
Bug 1492482 - Remove CPOW usage from browser_aboutnewtab_process_selection.js. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 39

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9012282 [details]
Bug 1492482 - Remove CPOW usage from browser_usercontext.js. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 40

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9012307 [details]
Bug 1492482 - Stop sending CPOWs with WebProgressChild messages. r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 41

[Andrea Marchesini [:baku]]

Comment on attachment 9012304 [details]
Bug 1492482 - Remove CPOW usage from browser_saveImageURL.js. r?baku

Andrea Marchesini [:baku] has approved the revision.

Comment 42

[Florian Quèze [:florian]]

Comment on attachment 9012275 [details]
Bug 1492482 - Remove CPOW usage from browser_pageinfo_image_info.js r?florian

Florian Quèze [:florian] has approved the revision.

Comment 43

[Nihanth Subramanya [:nhnt11]]

Comment on attachment 9012283 [details]
Bug 1492482 - Remove CPOW usage from browser_aboutSearchReset.js. r?nhnt11

Nihanth Subramanya [:nhnt11] has approved the revision.

Comment 44

[Mike Kaply [:mkaply]]

Comment on attachment 9012284 [details]
Bug 1492482 - Remove browser_abouthome_behavior.js test. r?mkaply

Mike Kaply [:mkaply] has approved the revision.

Comment 45

[Mike Kaply [:mkaply]]

Comment on attachment 9012271 [details]
Bug 1492482 - Remove CPOW usage from browser_keywordSearch_postData.js r?mkaply

Mike Kaply [:mkaply] has approved the revision.

Comment 46

[Julian Descottes [:jdescottes]]

Comment on attachment 9012300 [details]
Bug 1492482 - Remove CPOWs from devtools/client/debugger/test/mochitest/head.js. r?jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 47

[Julian Descottes [:jdescottes]]

Comment on attachment 9012296 [details]
Bug 1492482 - Remove CPOW usage from browser_dbg_event-listeners-02.js. r?jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 48

[Julian Descottes [:jdescottes]]

Comment on attachment 9012293 [details]
Bug 1492482 - Remove CPOW usage from browser_dbg_event-listeners-01.js. r?jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56f92aa110f0
Remove CPOW usage from browser_keywordSearch_postData.js r=mkaply
https://hg.mozilla.org/integration/autoland/rev/8bda47dfef15
Remove CPOW usage from browser_tab_dragdrop2.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c25d430da5b7
Remove CPOW usage from browser_pageinfo_image_info.js r=florian
https://hg.mozilla.org/integration/autoland/rev/9cedc276ac39
Remove CPOW usage from browser_Bug 1492482.js r=johannh
https://hg.mozilla.org/integration/autoland/rev/159f859490af
Remove CPOW usage from browser_urlbarHashChangeProxyState.js r=Gijs
https://hg.mozilla.org/integration/autoland/rev/17c32940a63f
Remove CPOW usage from browser_urlbarKeepStateAcrossTabSwitches.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/517aee4235da
Remove CPOW usage from browser_usercontext.js. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/8e71dda1db82
Remove CPOW usage from browser_aboutSearchReset.js. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/62deabc00236
Remove browser_abouthome_behavior.js test. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/b34f1ec15697
Remove CPOW usage from browser_1119088.js. r=mstange
https://hg.mozilla.org/integration/autoland/rev/6cbfcebf531f
Remove CPOW usage from browser_onboarding_skip_tour.js. r=ursula
https://hg.mozilla.org/integration/autoland/rev/0c2a8c43e38e
Remove CPOW usage from browser_onboarding_tourset.js. r=ursula
https://hg.mozilla.org/integration/autoland/rev/e36f11e68401
Remove CPOW usage from browser_dbg_event-listeners-01.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ac62c33e160e
Remove CPOW usage from browser_dbg_event-listeners-02.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/16d572f93a94
Remove CPOWs from devtools/client/debugger/test/mochitest/head.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/fe01cfeef13a
Remove CPOW usage from browser_aboutnewtab_process_selection.js. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/ae79eeefe39d
Remove CPOW usage from browser_readerMode_with_anchor.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/62448675e862
Remove CPOW usage from browser_datetime_picker.js. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/7cfc774d8178
Remove CPOW usage from browser_saveImageURL.js. r=baku
https://hg.mozilla.org/integration/autoland/rev/cfa50dc1f616
Stop sending CPOWs with WebProgressChild messages. r=Felipe

Comment 50

[Kris Maglione [:kmag]]

How many tests still have the uses-unsafe-cpows annotation after this?

Comment 51

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

(In reply to Kris Maglione [:kmag] from comment #50)
> How many tests still have the uses-unsafe-cpows annotation after this?

Good question. I actually forgot to remove it from the ones I just updated here - filed bug 1495885 for that.

Comment 52

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpows+%3D+true&case=false&regexp=false&path= returns a list of 186 matches. My patch in bug 1495885 removes 54, so that leaves 132.

Comment 53

[Kris Maglione [:kmag]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #52)
> https://searchfox.org/mozilla-central/search?q=uses-unsafe-
> cpows+%3D+true&case=false&regexp=false&path= returns a list of 186 matches.
> My patch in bug 1495885 removes 54, so that leaves 132.

:( Well, it's still an improvement. Thanks

Comment 54

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/56f92aa110f0
https://hg.mozilla.org/mozilla-central/rev/8bda47dfef15
https://hg.mozilla.org/mozilla-central/rev/c25d430da5b7
https://hg.mozilla.org/mozilla-central/rev/9cedc276ac39
https://hg.mozilla.org/mozilla-central/rev/159f859490af
https://hg.mozilla.org/mozilla-central/rev/17c32940a63f
https://hg.mozilla.org/mozilla-central/rev/517aee4235da
https://hg.mozilla.org/mozilla-central/rev/8e71dda1db82
https://hg.mozilla.org/mozilla-central/rev/62deabc00236
https://hg.mozilla.org/mozilla-central/rev/b34f1ec15697
https://hg.mozilla.org/mozilla-central/rev/6cbfcebf531f
https://hg.mozilla.org/mozilla-central/rev/0c2a8c43e38e
https://hg.mozilla.org/mozilla-central/rev/e36f11e68401
https://hg.mozilla.org/mozilla-central/rev/ac62c33e160e
https://hg.mozilla.org/mozilla-central/rev/16d572f93a94
https://hg.mozilla.org/mozilla-central/rev/fe01cfeef13a
https://hg.mozilla.org/mozilla-central/rev/ae79eeefe39d
https://hg.mozilla.org/mozilla-central/rev/62448675e862
https://hg.mozilla.org/mozilla-central/rev/7cfc774d8178
https://hg.mozilla.org/mozilla-central/rev/cfa50dc1f616