149317 - API Freeze - PageSetup call needs observer

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[rods (gone)]

Comment 1

[rods (gone)]

The call to show the page setup dialog needs an observer for those platforms
that have an "Apply" btn. This way the caller can monitor changes to the PS
before the dialog is ok'ed or cancelled.

Comment 2

[rods (gone)]

Attachment: patch

Patch adds nsIObserver arg to ShowPageSetup call, it is not used at this time
for 1.0.1, but will be used in the near future. The arg is passed into the XP
dialog calls also.

Comment 3

[kinmoz]

Comment on attachment 86452 [details] [diff] [review]
patch

sr=[e-mail]

If you remove the code that appends the observer to the dialog arg array ... as
discussed on AIM.

Comment 4

[rods (gone)]

Attachment: new patch

Made Kin's suggested changes. The observer is passed in and not used at all.

Comment 5

[rods (gone)]

Comment on attachment 86456 [details] [diff] [review]
new patch

bring Kin's sr forward

Comment 6

[dcone (gone)]

Comment on attachment 86456 [details] [diff] [review]
new patch

r=dcone

Comment 7

[rods (gone)]

Attachment: patch missed one call in some Mac platforms code

Comment 8

[rods (gone)]

fixed

Comment 9

[scottputterman]

adding adt1.0.1+.  Please check into the branch asap.

Comment 10

[Scott Collins]

Comment on attachment 86456 [details] [diff] [review]
new patch

a=scc (on behalf of drivers) for checkin to the mozilla1.0 branch.

when you check this into the branch, please change the mozilla1.0.1+ keyword to
fixed1.0.1

Comment 11

[rods (gone)]

fixed on branch