Closed
Bug 1493386
Opened 6 years ago
Closed 6 years ago
TB: Build config for profile-per-install and downgrade protection
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
937 bytes,
patch
|
rjl
:
review+
mossop
:
feedback+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1493315 +++ I want profile-per-install and downgrade protection to be configurable at build time so there are a couple of build config settings to do that here.
|
Assignee | |
Comment 1•6 years ago
|
||
I think, we can begin with enabling this two options at the start. When we see it doesn't work for TB, we can still switch the options, or what do you think?
|
|
Assignee | |
Updated•6 years ago
|
Summary: Build config for profile-per-install and downgrade protection → TB: Build config for profile-per-install and downgrade protection
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9011196 [details] [diff] [review] profile-protection.patch Thanks, but I'm not up to speed with this. Maybe we should ask a build person.
Attachment #9011196 -
Flags: review?(rob)
Attachment #9011196 -
Flags: review?(jorgk)
Attachment #9011196 -
Flags: feedback?(dtownsend)
|
|
||
Comment 3•6 years ago
|
||
Straight port of course: https://hg.mozilla.org/mozilla-central/rev/575545bc2b10#l1.12 but by moving the review, I'd like to make Rob aware.
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9011196 [details] [diff] [review] profile-protection.patch Review of attachment 9011196 [details] [diff] [review]: ----------------------------------------------------------------- Looks okay to me.
Attachment #9011196 -
Flags: review?(rob) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/eb028fd3dc3e Port bug 1493315 to TB: Build config for dedicated profiles and downgrade protection. r=rjl
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 64.0
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9011196 [details] [diff] [review] profile-protection.patch Review of attachment 9011196 [details] [diff] [review]: ----------------------------------------------------------------- Not a build peer myself, but this seems pretty straightforward.
Attachment #9011196 -
Flags: feedback?(dtownsend) → feedback+
|
|
||
Comment 7•6 years ago
|
||
Thanks Dave, you wrote the same code in bug 1493315 and I just wanted to make you aware that we're following your "profile-per-install" activities.
You need to log in
before you can comment on or make changes to this bug.
Description
•