1493602 - Unable to change preferences on Xfinity while Tracking Protection Basic is enabled

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Oana Arbuzov [:oanaarbuzov]]

Attachment: ButtonsNotFunctional.gif

[Environment:]
Browser / Version: Firefox Nightly 64.0a1 (2018-09-23) 
Operating System: Windows 10 Pro, MacOS 10.13.6 

[Prerequisites:]
    1. Account available.
    2. Tracking Protection Basic enabled.
[Steps to Reproduce:]
    1. Navigate to https://pc2.mypreferences.com/Comcast/OptDown/opt-down/#/ 
    2. Type in valid valid email address.
    3. Try to change the preferences (e.g “Unsubscribe all” / “Customize what I receive”).
        
[Expected Behavior:]
Preferences can be changed.
 
[Actual Behavior:]
Preferences can’t be changed, buttons are not functional.

Comment 1

[Oana Arbuzov [:oanaarbuzov]]

The issue is related to `trackingprotection` breakage.

Looking at the devtools console, here are the blocked resources:
The resource at “https://www.googletagmanager.com/gtm.js?id=GTM-P53ZR3” was blocked because content blocking is enabled.

So below are the domains to test:
- ​googletagmanager.com

I opened the URL in a fresh browser profile (Firefox Nightly 64, uMatrix installed, normal mode) and loaded the page. The page was blank.

I disabled the Spoof Referrer option in uMatrix and then WHITELISTED:
- cloudflare.com (including related domains)
and the page loaded.

I then WHITELISTED:
- googletagmanager.com
- google-analytics.com 

So in conclusion:
- googletagmanager.com is in Advertisingcategory = [tp-ads]
- google-analytics.com is in Analytics category = [tp-anaytics]

Comment 2

[Oana Arbuzov [:oanaarbuzov]]

Attachment: uMatrixResults.png

Added uMatrix results.

Comment 3

[Firefox Bug Husbandry Bot]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Comment 4

[Firefox Bug Husbandry Bot]

See bug 1547409. Migrating whiteboard priority tags to program flags.

Comment 5

[Thomas Wisniewski [:twisniewski]]

I see this in the console when I click on an option like "unsubscribe all":

TypeError: "ga.getAll is not a function"
    triggerGAEvent mainController.js:40
    unsubscribeAll mainController.js:56
    Angular 69
angular.js:14642:15

Meaning this is likely related to Google Analytics. Sure enough, if I shim the request to https://www.google-analytics.com/analytics.js with a minimal version that just defines ga.getAll as a no-op function, the site features seem to work. So we ought to be able to shim and fix this.

Comment 6

[Oana Arbuzov [:oanaarbuzov]]

The issue no longer reproduce regardless if ETP is Strict or Standard, I can change the preferences (Subscribe to all/Unsubscribe from all).

Tested with:
Browser / Version: Firefox Nightly 86.0a1 (2021-01-21)
Operating System: Windows 10 Pro

Comment 7

[Mathew Hodson]

I believe this was fixed by the Google Analytics shim added in bug 1637329.

Comment 8

[Mathew Hodson]

The shim was enabled in Firefox 87 by bug 1693386.