1493680 - [performance-new] The preferences are not saved anymore

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Julien Wajsberg [:julienw]]

Bug 1222047 changed how the preference front is retrieved. The problem is that it's now a promise, and our code doesn't account for this.

Comment 1

[Julien Wajsberg [:julienw]]

STR is simple:
1. enable the new performance panel from devtools settings, and restart the devtools.
2. open the performance panel.
3. change the preferences from the default ones.
4. close devtools, open the performance panel again.
=> look at how the preferences are back to default.

Comment 2

[Julien Wajsberg [:julienw]]

I'd like to track this for 63. It's not important or even impactful for end-users because the panel isn't enabled by default, but it can be important for gecko developers doing some remote profiling on 63.

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment

Comment 5

[Greg Tatum [:gregtatum]]

Comment on attachment 9011484 [details]
Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment

Greg Tatum [:gregtatum] has approved the revision.

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 9011484 [details]
Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment

Approval Request Comment
[Feature/Bug causing the regression]: bug 1222047
[User impact if declined]: end-user: none; but gecko developers won't be able to change the preferences for the profiler in a remote setting.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: because the code is not exposed to end-users
[String changes made/needed]: none

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d5149546bf
use the new getFront API and properly wait for the promise fullfilment r=gregtatum

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d3d5149546bf

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9011484 [details]
Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment

Low risk as this is not exposed to end-users, uplift approved for 63 beta 10, thanks.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9841fa1b5f14