1493938 - Detailed commit message is removed in phabricator and landed patch

Status: RESOLVED DUPLICATE of bug 1494372

(Conduit :: Phabricator, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I was working on bug 1493896 earlier today. The first commit which I submitted via `moz-phab submit` missed some code and also a detailed commit message. So after updating the patch I added a detailed commit message when amending the changes.

So locally it looks like:

> % hg log -r 7835418112ca -v
> changeset:   491182:7835418112ca
> bookmark:    wpt_download_manifest
> parent:      491144:b7aa0f3bdf68
> user:        Henrik Skupin <[e-mail]>
> date:        Tue Sep 25 09:05:24 2018 +0100
> files:       testing/web-platform/manifestdownload.py
> description:
> Bug 1493896 - [wptrunner] Skipping download of manifest without active internet connection. r?jgraham
> 
> Without an internet connection `request.get()` will throw an exception
> and as such `req` never gets set. So we have to skip the download if
> `req` is None.
> 
> Differential Revision: https://phabricator.services.mozilla.com/D6753

Then I submitted the changes again, and while the code change is visible the detailed commit message is not in phabricator. This is annoying because it cannot be reviewed.

But what should be kinda blocking is that the whole detailed message is not part of the landed patch! See:

https://hg.mozilla.org/mozilla-central/rev/5d3604ac613e

Comment 1

[Mark Côté [:mcote]]

Ah I just filed a bug about this.  Duping it over.