Closed Bug 1493969 Opened 2 years ago Closed 2 years ago
Refactor the user interface update code of download elements
46 bytes, text/x-phabricator-request
|Details | Review|
52 bytes, text/x-github-pull-request
|Details | Review|
This refactoring should also take care of the fact that the New Tab Page code misuses inheritance from DownloadsViewUI.DownloadElementShell to access a few label getters, but does not link the inherited objects to actual individual DOM elements. This blocks the removal of the "download" binding.
Hi Ursula, I'm not quite sure what the review and landing process is for the New Tab page, but I saw you landed code in this area so maybe you can help. Hopefully this doesn't require a GitHub pull request, but even if it does, keep in mind that the changes made by this code must land synchronized.
Marco, this is also ready for review on the browser front-end side of the code.
Hi Paolo, don't worry about the github changes! When this lands I can update the activity stream repo with these changes to the files in browser/components/newtab and they'll sync up that way. I can review the changes in your patch for those files. Thanks!
Comment on attachment 9011891 [details] Bug 1493969 - Refactor the user interface update code of download elements Ursula Sarracini (:ursula) has approved the revision.
Thanks Ursula! I think this is ready to land after Marco's review. There are some tryserver failures, but it seems they are permanent on try, as they fail on the base revision too: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5f58933e72e3135a70c1c42dab13df57de1d38
The testing/firefox-ui/tests/functional/safebrowsing/test_initial_download.py failure on try looks more frequent and with a different error message from the one tracked in bug 1490999. It seems to fail in every opt build (thus it sounds timing related, like something is not waiting long enough). I have no idea if it's related to this or not, but pay attention cause it may end up causing a backout.
Comment on attachment 9011891 [details] Bug 1493969 - Refactor the user interface update code of download elements Marco Bonardo [::mak] has approved the revision.
Yes, I don't think the failure is from bug 1490999. I'm thinking it may be related to the try builds being artifact builds, let's see what happens with a full build instead: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2c5193cb00272a94f311d26f50767450b1a6f43
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c869bea1ed94 Refactor the user interface update code of download elements. r=mak,ursula
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/931ed2e441190908d7f8df1cc6a699d09efe9cf6 Backport Bug 1493969 - Refactor the user interface update code of download element r=ursula (#4453)
You need to log in before you can comment on or make changes to this bug.