Refactor the user interface update code of download elements

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

unspecified
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 months ago
This refactoring should also take care of the fact that the New Tab Page code misuses inheritance from DownloadsViewUI.DownloadElementShell to access a few label getters, but does not link the inherited objects to actual individual DOM elements. This blocks the removal of the "download" binding.
(Assignee)

Comment 3

7 months ago
Hi Ursula, I'm not quite sure what the review and landing process is for the New Tab page, but I saw you landed code in this area so maybe you can help. Hopefully this doesn't require a GitHub pull request, but even if it does, keep in mind that the changes made by this code must land synchronized.
Flags: needinfo?(usarracini)
(Assignee)

Comment 4

7 months ago
Marco, this is also ready for review on the browser front-end side of the code.
Flags: needinfo?(mak77)
Hi Paolo, don't worry about the github changes! When this lands I can update the activity stream repo with these changes to the files in browser/components/newtab and they'll sync up that way. I can review the changes in your patch for those files. Thanks!
Flags: needinfo?(usarracini)
Comment on attachment 9011891 [details]
Bug 1493969 - Refactor the user interface update code of download elements

Ursula Sarracini (:ursula) has approved the revision.
Attachment #9011891 - Flags: review+
(Assignee)

Comment 8

7 months ago
Thanks Ursula! I think this is ready to land after Marco's review.

There are some tryserver failures, but it seems they are permanent on try, as they fail on the base revision too:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5f58933e72e3135a70c1c42dab13df57de1d38
Flags: needinfo?(mak77)
The testing/firefox-ui/tests/functional/safebrowsing/test_initial_download.py failure on try looks more frequent and with a different error message from the one tracked in bug 1490999. It seems to fail in every opt build (thus it sounds timing related, like something is not waiting long enough). I have no idea if it's related to this or not, but pay attention cause it may end up causing a backout.
Comment on attachment 9011891 [details]
Bug 1493969 - Refactor the user interface update code of download elements

Marco Bonardo [::mak] has approved the revision.
Attachment #9011891 - Flags: review+
(Assignee)

Comment 11

7 months ago
Yes, I don't think the failure is from bug 1490999. I'm thinking it may be related to the try builds being artifact builds, let's see what happens with a full build instead:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2c5193cb00272a94f311d26f50767450b1a6f43

Comment 12

7 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c869bea1ed94
Refactor the user interface update code of download elements. r=mak,ursula

Comment 13

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c869bea1ed94
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64

Comment 14

7 months ago
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/931ed2e441190908d7f8df1cc6a699d09efe9cf6
Backport Bug 1493969 - Refactor the user interface update code of download element r=ursula (#4453)
You need to log in before you can comment on or make changes to this bug.