ExtensionPopups.jsm implicitly relies on an about:blank window being loaded by any non-remote browsers it creates

NEW
Unassigned

Status

defect
P2
normal
7 months ago
4 months ago

People

(Reporter: Gijs, Unassigned)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 months ago
From IRC:

16:37:44 <@Gijs> aswan: the same-process browser binding implementation touches browser.securityUI in the constructor
16:37:47 <@Gijs> that touches browser.contentWindow
16:37:55 <@Gijs> that forces the creation of a dummy about:blank document
16:38:04 <@Gijs> I'm trying to fix this in bug 1493655
16:38:05 <firebot> https://bugzil.la/1493655 — ASSIGNED, gijskruitbosch+bugs@gmail.com — nsISecureBrowserUI::Init should take a docshell instead of a content window

With that getter removed, a number of webextension tests go orange, cf. https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=201418654&revision=aa93743aa6b57f7922aa0f17ace8f6294fea812b .

It's not entirely clear to me off-hand why that is, but it goes away if I make ExtensionPopups.jsm touch browser.contentWindow for any non-remote browsers it creates, to simulate what the docshell code used to do. I'm splitting this off so that it's possible to make progress on bug 1493655 without blocking on figuring out the webextensions tests.
Priority: -- → P1
(Reporter)

Updated

7 months ago
Blocks: 1493606
Priority: P1 → P2
You need to log in before you can comment on or make changes to this bug.