1494029 - ExtensionPopups.jsm implicitly relies on an about:blank window being loaded by any non-remote browsers it creates

Status: NEW

(WebExtensions :: General, defect, P3)

Description

[:Gijs (he/him)]

From IRC:

16:37:44 <@Gijs> aswan: the same-process browser binding implementation touches browser.securityUI in the constructor
16:37:47 <@Gijs> that touches browser.contentWindow
16:37:55 <@Gijs> that forces the creation of a dummy about:blank document
16:38:04 <@Gijs> I'm trying to fix this in bug 1493655
16:38:05 <firebot> https://bugzil.la/1493655 — ASSIGNED, [e-mail] — nsISecureBrowserUI::Init should take a docshell instead of a content window

With that getter removed, a number of webextension tests go orange, cf. https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=201418654&revision=aa93743aa6b57f7922aa0f17ace8f6294fea812b .

It's not entirely clear to me off-hand why that is, but it goes away if I make ExtensionPopups.jsm touch browser.contentWindow for any non-remote browsers it creates, to simulate what the docshell code used to do. I'm splitting this off so that it's possible to make progress on bug 1493655 without blocking on figuring out the webextensions tests.

Comment 1

[:Gijs (he/him)]

I don't really understand why this got moved to android - pretty sure this affects desktop?

Comment 2

[Shane Caraveo (:mixedpuppy)]

We don't use non-remote browsers on desktop. We have some non-remote tests in toolkit, but that is only to support android.

Comment 3

[:Gijs (he/him)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)

We don't use non-remote browsers on desktop. We have some non-remote tests in toolkit, but that is only to support android.

Ah, ok - sorry, that wasn't obvious to me.

Comment 4

[Shane Caraveo (:mixedpuppy)]

(In reply to :Gijs (he/him) from comment #3)

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)

We don't use non-remote browsers on desktop. We have some non-remote tests in toolkit, but that is only to support android.

Ah, ok - sorry, that wasn't obvious to me.

no problem. A slight correction though, this is controlled by extensions.webextensions.remote which defaults to true on desktop. It could be flipped to false. It should probably become a build-time option.

Comment 5

[:Gijs (he/him)]

Given that we don't support fennec on current m-c anymore, and the geckoview implementation is quite different, should all the support for non-remote browsers just be removed at this point?

Comment 6

[Shane Caraveo (:mixedpuppy)]

From a Firefox/Toolkit perspective I'm happy to remove non-remote support everywhere. I'd like a definitive OK from someone in geckoview that would know whether this will create a problem for them.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

GV/Android doesn't support remote extensions yet, sorry. We need multi-e10s support first which is being worked on as we speak. You can follow Bug 1535365 and dependents.

Comment 8

[Rob Wu [:robwu]]

ExtensionPopups.jsm is only used on desktop, not mobile. Bug 1613141 is about removing it from desktop, so I'll close this bug once the other has been resolved.