Closed Bug 1535365 Opened 5 years ago Closed 4 months ago

Add support for extension process.

Categories

(GeckoView :: Extensions, enhancement, P2)

Unspecified
Android
enhancement

Tracking

(firefox76 fixed)

RESOLVED FIXED
Tracking Status
firefox76 --- fixed

People

(Reporter: agi, Assigned: agi)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

(Whiteboard: [geckoview:2022q4] [addons-jira])

Attachments

(2 files)

Now that we have at least some WebExtension support we should look into running extensions stuff in its own process similar to what desktop does.

P2 because an extension process is not a blocker for Fenix MVP.

OS: All → Android
Priority: -- → P2
See Also: → android-e10s-multi
Blocks: 1534640

A lot of the plumbing for this is similar to e10s so I'm going to block this on that.

Depends on: android-e10s-multi
Rank: 45
No longer blocks: 1511077

Mass moving bugs to the Extension component.

Component: General → Extensions
No longer blocks: 1534640
See Also: → 1502525
See Also: → 1613141
Whiteboard: [geckoview:m76]
Assignee: nobody → agi
Rank: 45 → 10
Whiteboard: [geckoview:m76]
Whiteboard: [geckoview:m77]
Blocks: 1626349
Priority: P2 → P1
Depends on: 1619798
No longer depends on: android-e10s-multi
Depends on: 1627106
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c3c02b4f8ca
Enable the extension process. r=snorp,aklotz
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Until Bug 1355239 is fixed we cannot leave this on, since it causes extensions to randomly die.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: leave-open
Depends on: 1355239

We don't currently restart the extension process and this causes extensions to
randomly stop working when Android kills the extension process.

We can re-enable it once Bug 1355239 is fixed.

Severity: normal → blocker
Rank: 10 → 1
Priority: P1 → P2
Whiteboard: [geckoview:m77] → [geckoview:p1]
Severity: blocker → normal
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba0d3a69fea
Disable extension process. r=snorp,rbarker
See Also: → 1622610
Depends on: 1630066
Depends on: 1630073
Depends on: 1630064
Depends on: 1423168

Tracking this bug for Android Fission milestone M2 (pass tests with Fission enabled).

Whiteboard: [geckoview:p1] → [geckoview:p1] [fission:android:m2]
See Also: → 1683157

Extension process doesn't need to block Android Fission.

Whiteboard: [geckoview:p1] [fission:android:m2] → [geckoview:p1] [fission:android]
See Also: → 1724094
Blocks: 1724099

The leave-open keyword is there and there is no activity for 6 months.
:agi, maybe it's time to close this bug?

Flags: needinfo?(agi)

Still relevant.

Flags: needinfo?(agi)
Keywords: leave-open

The extension process is not required for Android Fission, but would be nice to have.

Whiteboard: [geckoview:p1] [fission:android] → [geckoview:p1]
Blocks: 1560845
Whiteboard: [geckoview:p1] → [geckoview:p1] [geckoview:2022h2?]
Priority: P2 → P3
Whiteboard: [geckoview:p1] [geckoview:2022h2?]
Assignee: agi → nobody

The extension process is a prerequisite for MV3 support.

Whiteboard: [geckoview:2022h1] [geckoview:m106?]
Priority: P3 → P2
Whiteboard: [geckoview:2022h1] [geckoview:m106?] → [geckoview:2022q4]
Severity: normal → S3
Blocks: 1796184
Blocks: 1797558
See Also: → CVE-2023-28160
Rank: 1 → 222

Enhancements should have severity N/A.

Severity: S3 → N/A
Blocks: 1796175
Depends on: 1815957
Depends on: 1817019
Rank: 222 → 200
Whiteboard: [geckoview:2022q4] → [geckoview:2022q4] [addons-jira]
Depends on: 1844138
Blocks: 1423168
No longer depends on: 1423168
Depends on: 1849341
Depends on: 1850280

We should close this bug when we flip the pref by default and ride the trains.

(In reply to William Durand [:willdurand] from comment #20)

We should close this bug when we flip the pref by default and ride the trains.

https://bugzilla.mozilla.org/show_bug.cgi?id=1859533 is implemented and verified. This bug can be closed?

Flags: needinfo?(wdurand)
Flags: needinfo?(wdurand)

(In reply to Chih-Hsuan Yen [:yan12125] (UTC+8) from comment #21)

(In reply to William Durand [:willdurand] from comment #20)

We should close this bug when we flip the pref by default and ride the trains.

https://bugzilla.mozilla.org/show_bug.cgi?id=1859533 is implemented and verified. This bug can be closed?

The preference is currently controlled in Fenix through Nimbus.

The pref still defaults to false at the Gecko/GeckoView layer (in mozilla-central):

Note for completeness: The current rollout only controls Fenix applications. An example of a non-Fenix app in production is Firefox Focus. While it doesn't support third-party add-ons, some internal components are implemented as extensions (webcompat), and enabling out-of-process extensions there may result in unexpected results, especially because so far our primary focus of the out-of-process extension rollout has been Fenix.

Got it, thank you very much for detailed explanations! Indeed bug 1859533 only flips the default value for the nimbus experiment extensions-process (which controls the config extensions.webextensions.remote [1][2]).

[1] https://github.com/mozilla-mobile/firefox-android/commit/e59032a7d970167b7b67f7867c50ee87a0659233
[2] https://searchfox.org/mozilla-central/rev/02841791400cf7cf5760c0cfaf31f5d772624253/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java#571

Depends on: 1867597
Target Milestone: mozilla76 → ---

Looks like this work is already completed.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 months ago
Resolution: --- → FIXED
Assignee: nobody → agi
See Also: → 1880856
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: