1494042 - Update webrender to 43e8d85789efb95099affe3257a9c254ef3d2f4c

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Darkspirit]

+++ This bug was initially created as a clone of Bug #1493890 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Jean-Yves Avenard [:jya]]

For the next webrender update, https://phabricator.services.mozilla.com/D6688 is required.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c848b37cc93cfe90f713559128399608ead46556

Comment 3

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=311fc08763fc733bf104f241d0a7191e09967205

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3122696fa3fa
Update webrender to commit 43e8d85789efb95099affe3257a9c254ef3d2f4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/c897c7bab868
Update Cargo lockfile and re-vendor rust dependencies
https://hg.mozilla.org/integration/mozilla-inbound/rev/f782eaa9521c
Re-generate FFI header
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3768a7ecb1
Update bindings for addition of ColorDepth

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3122696fa3fa
https://hg.mozilla.org/mozilla-central/rev/c897c7bab868
https://hg.mozilla.org/mozilla-central/rev/f782eaa9521c
https://hg.mozilla.org/mozilla-central/rev/ea3768a7ecb1

Comment 6

[Ionuț Goldan [:igoldan]]

Big perf improvements!

== Change summary for alert #16182 (as of Wed, 26 Sep 2018 01:51:36 GMT) ==

Improvements:

 33%  displaylist_mutate linux64-qr opt e10s stylo          7,790.13 -> 5,258.09
 24%  displaylist_mutate windows10-64-qr opt e10s stylo     7,044.15 -> 5,319.87
  5%  tp5o_scroll linux64-qr opt e10s stylo                 4.22 -> 4.01

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16182

Comment 7

[Bobby Holley (:bholley)]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> Big perf improvements!
> 
> == Change summary for alert #16182 (as of Wed, 26 Sep 2018 01:51:36 GMT) ==
> 
> Improvements:
> 
>  33%  displaylist_mutate linux64-qr opt e10s stylo          7,790.13 ->
> 5,258.09
>  24%  displaylist_mutate windows10-64-qr opt e10s stylo     7,044.15 ->
> 5,319.87
>   5%  tp5o_scroll linux64-qr opt e10s stylo                 4.22 -> 4.01
> 
> For up to date results, see:
> https://treeherder.mozilla.org/perf.html#/alerts?id=16182

This is presumably from [1] - nice job Matt!

[1] https://github.com/servo/webrender/pull/3117

Comment 8

[Ionuț Goldan [:igoldan]]

Also noticed this AWSY improvement:

== Change summary for alert #16185 (as of Wed, 26 Sep 2018 01:51:36 GMT) ==

Improvements:

  3%  Heap Unclassified linux64-qr opt stylo     305,572,202.08 -> 297,477,023.52

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16185