1493198 - Add support for 10/12 bits YUV image in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Jean-Yves Avenard [:jya]]

Similar to bug 1469711 but with Web Render

Add support for 10/12 bits YUV image

Comment 1

[Jean-Yves Avenard [:jya]]

Going to have a try at this over the next week or so

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P1. Make ImageDescriptor::is_opaque an enum and rename accordingly.

Prevent future ambiguous conversion once a bit depth int is added.
Also more self-explanatory

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P2. Use enum for describing color depth.

Depends on D6662

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 9011446 [details]
Bug 1493198 - P1. Make ImageDescriptor::is_opaque an enum and rename accordingly.

Nicolas Silva [:nical] has approved the revision.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P4. Add support for 10/12 bits YUV image to WebRender (bindings)

Depends on D6663

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P4. Add support for 10/12 bits YUV image to WebRender

To be pushed via PR
https://github.com/servo/webrender/pull/3113

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P5. Don't restrict high bit depth images on Windows

Both D3D11 compositor and WebRender now supports 10/12 bits images.

Depends on D6688

Comment 8

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9011447 [details]
Bug 1493198 - P2. Use enum for describing color depth.

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 9

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9011545 [details]
Bug 1493198 - P4. Add support for 10/12 bits YUV image to WebRender (bindings)

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1493198 - P3. Fix typo and use move semantics.

Depends on D6663

Comment 11

[Nicolas Silva [:nical]]

Comment on attachment 9011749 [details]
Bug 1493198 - P3. Fix typo and use move semantics.

Nicolas Silva [:nical] has approved the revision.

Comment 12

[Darkspirit]

Attachment: Screenshot_20180925_173519.png

Debian Testing, KDE, Xorg, Nvidia GTX 1060 (driver 390.87)

Colors seem to be a bit wrong.
(But with Basic compositing I get white backgrounds and everything looks the same.)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d97bf44347933bd4ad89aa080d83a005b74a9985

mozregression --repo try --launch d97bf44347933bd4ad89aa080d83a005b74a9985 --pref gfx.webrender.all:true -a https://www.avenard.org/htmltests/tests/webm-hdr.html

Comment 13

[Darkspirit]

It looks the same on Ubuntu 18.04 LTS, GTX 1060 (390.48), 2560x1440.

Comment 14

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9011571 [details]
Bug 1493198 - P5. Don't restrict high bit depth images on Windows

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa105d110671
P1. Make ImageDescriptor::is_opaque an enum and rename accordingly. r=nical
https://hg.mozilla.org/integration/autoland/rev/afdc1b5bb3d9
P2. Use enum for describing color depth. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b571f960e636
P3. Fix typo and use move semantics. r=nical

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fa105d110671
https://hg.mozilla.org/mozilla-central/rev/afdc1b5bb3d9
https://hg.mozilla.org/mozilla-central/rev/b571f960e636

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca2d75deffe6
P4. Add support for 10/12 bits YUV image to WebRender (bindings) r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/32bb9ea9e273
P5. Don't restrict high bit depth images on Windows r=bryce

Comment 18

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ca2d75deffe6
https://hg.mozilla.org/mozilla-central/rev/32bb9ea9e273