Add support for 10/12 bits YUV image in WebRender

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P2
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 2 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(6 attachments, 1 obsolete attachment)

Assignee

Description

8 months ago
Similar to bug 1469711 but with Web Render

Add support for 10/12 bits YUV image
Assignee

Comment 1

8 months ago
Going to have a try at this over the next week or so
Assignee: nobody → jyavenard
Component: Graphics: Layers → Graphics: WebRender
Priority: -- → P2
Assignee

Comment 2

8 months ago
Prevent future ambiguous conversion once a bit depth int is added.
Also more self-explanatory
Comment on attachment 9011446 [details]
Bug 1493198 - P1. Make ImageDescriptor::is_opaque an enum and rename accordingly.

Nicolas Silva [:nical] has approved the revision.
Attachment #9011446 - Flags: review+
Assignee

Comment 7

8 months ago
Both D3D11 compositor and WebRender now supports 10/12 bits images.

Depends on D6688
Comment on attachment 9011447 [details]
Bug 1493198 - P2. Use enum for describing color depth.

Matt Woodrow (:mattwoodrow) has approved the revision.
Attachment #9011447 - Flags: review+
Comment on attachment 9011545 [details]
Bug 1493198 - P4. Add support for 10/12 bits YUV image to WebRender (bindings)

Matt Woodrow (:mattwoodrow) has approved the revision.
Attachment #9011545 - Flags: review+
Comment on attachment 9011749 [details]
Bug 1493198 - P3. Fix typo and use move semantics.

Nicolas Silva [:nical] has approved the revision.
Attachment #9011749 - Flags: review+
Attachment #9011545 - Attachment description: Bug 1493198 - P3. Add support for 10/12 bits YUV image to WebRender (bindings) → Bug 1493198 - P4. Add support for 10/12 bits YUV image to WebRender (bindings)
Attachment #9011571 - Attachment description: Bug 1493198 - P5. Don't restrict high bit depth images on Windows → Bug 1493198 - P6. Don't restrict high bit depth images on Windows
Debian Testing, KDE, Xorg, Nvidia GTX 1060 (driver 390.87)

Colors seem to be a bit wrong.
(But with Basic compositing I get white backgrounds and everything looks the same.)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d97bf44347933bd4ad89aa080d83a005b74a9985

mozregression --repo try --launch d97bf44347933bd4ad89aa080d83a005b74a9985 --pref gfx.webrender.all:true -a https://www.avenard.org/htmltests/tests/webm-hdr.html
It looks the same on Ubuntu 18.04 LTS, GTX 1060 (390.48), 2560x1440.
Comment on attachment 9011571 [details]
Bug 1493198 - P5. Don't restrict high bit depth images on Windows

Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9011571 - Flags: review+

Comment 15

8 months ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa105d110671
P1. Make ImageDescriptor::is_opaque an enum and rename accordingly. r=nical
https://hg.mozilla.org/integration/autoland/rev/afdc1b5bb3d9
P2. Use enum for describing color depth. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b571f960e636
P3. Fix typo and use move semantics. r=nical
Depends on: 1494150

Comment 16

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fa105d110671
https://hg.mozilla.org/mozilla-central/rev/afdc1b5bb3d9
https://hg.mozilla.org/mozilla-central/rev/b571f960e636
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Attachment #9011571 - Attachment description: Bug 1493198 - P6. Don't restrict high bit depth images on Windows → Bug 1493198 - P5. Don't restrict high bit depth images on Windows

Comment 17

8 months ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca2d75deffe6
P4. Add support for 10/12 bits YUV image to WebRender (bindings) r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/32bb9ea9e273
P5. Don't restrict high bit depth images on Windows r=bryce
Attachment #9011550 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.