1494178 - Attempt to load Widevine CDM interface 10 before falling back to CDM interface 9

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The groundwork to have Firefox able to instantiate Widevine CDMs with interface verison 10 has been landed across several bugs:
- bug 1486502
- bug 1487811
- bug 1491117
- bug 1491889

As part of our update to Widevine CDM version 4.10.1146.0 (where the second number is the interface version: 10), we should have Firefox attempt to load CDMs with the newer interface, and fall back to version 9 of the interface if this does not succeed.

This is the strategy previously used during updates, and means that we do not need to roll out central changes at the same time as updating balrog rules. Users will have compatibility with the current CDM (interface 9) until we deploy 10, at which point that will also work.

One area to keep an eye on as we do this is the new CDM's expectation of explicit flagging of samples as encrypted or unencrypted. Previously the CDM would determine this by examining clear and encrypted ranges passed to it -- 0 encrypted ranges would be interpreted as clear. Now, however samples must be explicitly marked with an enum, and a sample marked as encrypted with 0 encrypted ranges will be refused by the CDM. The WebM case for this was handled in bug 1491117. However, I plan to  implement further checks and logging to detect and fix up such samples that would be rejected by the CDM. This will allow us to track if any demuxers are still emitting data that could be problematic while we bake the new interface.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fad9357fb12daf1f26d30b2c246b9464832ef6f

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1494178 - Add check to ChromiumCDMChild to mark samples with 0 encrypted bytes as unencrypted. r=cpearce

With the addition of an explicit encryption enum for CDM10 input data, if a
sample has 0 encrypted bytes it must be marked as unencrypted. Historically we
could let the CDM figure out based on the unencrypted + encrypted bytes.
However, if we mark a sample as encrypted but it has 0 encrypted bytes, the CDM
will fail to decrypt.

This changeset adds a check to gracefully handle samples that are marked as
encrypted but with no encrypted ranges. In such cases we mark the data as
unencrypted and log that such data was encountered. This means we don't break
playback of encrypted media should we overlook such cases, but have better
detection via logging.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1494178 - Attempt to instantiate CDM10 before CDM9. r=cpearce

Depends on D6873

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 9012025 [details]
Bug 1494178 - Add check to ChromiumCDMChild to mark samples with 0 encrypted bytes as unencrypted. r=cpearce

Chris Pearce (:cpearce) has approved the revision.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 9012026 [details]
Bug 1494178 - Attempt to instantiate CDM10 before CDM9. r=cpearce

Chris Pearce (:cpearce) has approved the revision.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=217d2ae16224690ef4c2954f7534adffa842525a

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26571ea7c1925e0b71c399a2dccc34362c1d9683

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6f8e822851a
Add check to ChromiumCDMChild to mark samples with 0 encrypted bytes as unencrypted. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/14e7673d10f7
Attempt to instantiate CDM10 before CDM9. r=cpearce

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e6f8e822851a
https://hg.mozilla.org/mozilla-central/rev/14e7673d10f7

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9012025 [details]
Bug 1494178 - Add check to ChromiumCDMChild to mark samples with 0 encrypted bytes as unencrypted. r=cpearce

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Please see Bug 1518525 for details and motivation.

Further notes: this is the fourth bug in a series tracked by bug 1518525. Could we please uplift all patches on this bug? Please see https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9976fb4de94bf0933f1faa8118154961fac20fb&selectedJob=220243631 for a try push where these patches have been grafted onto esr60.

User impact if declined: Failure to playback premium media.

Fix Landed on Version: 64

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The code here landed and baked since 64. I have verified that the code works when grafted onto esr60.

String or UUID changes made by this patch: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9012025 [details]
Bug 1494178 - Add check to ChromiumCDMChild to mark samples with 0 encrypted bytes as unencrypted. r=cpearce

Needed for ESR60 to continue to support Widevine video playback in the very near future. Approved for 60.5.0esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/757faffe20e3
https://hg.mozilla.org/releases/mozilla-esr60/rev/e46ea5747b2e